-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Description
Use case
Create from:
flutter/engine#36963 (comment)
Now we have too many builders, NewEngineIntentBuilder, CachedEngineIntentBuilder, as well as the increase of NewEngineInGroupIntentBuilder. They have some common parameters (especially NewEngineIntentBuilder and NewEngineInGroupIntentBuilder, because they are starting a new engine), in FlutterActivity, FlutterFragmentActivity, FlutterFragment all appear.
Proposal
Abstract a Builder class with some parameters used by Dart like entryPoint, initialRoute, dartEntrypointArgs. Then Actvitity or fragments of the Builder extends from this class, and contains specific attributes, such as activityClass/fragmentClass. Many of such NewEngineIntentBuilder and NewEngineInGroupIntentBuilder fields can be Shared.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team