Skip to content

In flutter doctor -v, when JRE is too out-of-date to run sdkmanager, print a helpful error message #138762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 21, 2023
Merged

In flutter doctor -v, when JRE is too out-of-date to run sdkmanager, print a helpful error message #138762

merged 7 commits into from
Nov 21, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Nov 20, 2023

Closes #138132. See this issue for more information.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 20, 2023
christopherfujino
christopherfujino approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos
Copy link
Contributor Author

andrewkolos commented Nov 21, 2023

LGTM

Thanks! I appreciate the good level of scrutiny you put into this review

@christopherfujino
Copy link
Contributor

christopherfujino commented Nov 21, 2023

LGTM

Thanks! I appreciate the good level of scrutiny you put into this review

that's a charitable way to put it :)

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 21, 2023
@auto-submit auto-submit bot merged commit cf09a8a into flutter:master Nov 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
3b30441 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
168656b 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
cef2832 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
82805aa 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
f3bbe0f 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
cf6d797 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 22, 2023
@engine-flutter-autoroll
Manual roll Flutter from ab721f9 to 14549b3 (20 revisions) (#5466)
6c5ad9e 
Manual roll requested by tarrinneal@google.com

flutter/flutter@ab721f9...14549b3

2023-11-22 yjbanov@google.com make FakeView not send Scene and semantics to the engine (flutter/flutter#138849)
2023-11-22 36861262+QuncCccccc@users.noreply.github.com Update the default outline color for `OutlinedButton` (flutter/flutter#138768)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c954a64c509b to 342fb003b11f (1 revision) (flutter/flutter#138903)
2023-11-22 engine-flutter-autoroll@skia.org Roll Packages from c9933fc to 2102327 (3 revisions) (flutter/flutter#138895)
2023-11-22 fluttergithubbot@gmail.com Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be unflaky (flutter/flutter#138886)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from d55b673f895c to c954a64c509b (1 revision) (flutter/flutter#138894)
2023-11-22 42216813+eliasyishak@users.noreply.github.com Add `commandHasTerminal` parameter + apple usage event + `sendException` events for `package:unified_analytics` (flutter/flutter#138806)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6c8f7b566a22 to d55b673f895c (1 revision) (flutter/flutter#138890)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from dda2499df48a to 6c8f7b566a22 (1 revision) (flutter/flutter#138875)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ae1d5318257 to dda2499df48a (4 revisions) (flutter/flutter#138872)
2023-11-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cf9d90d59e1 to 1ae1d5318257 (8 revisions) (flutter/flutter#138861)
2023-11-22 jacksongardner@google.com Revert "Reland VelocityTracker update (again)" (flutter/flutter#138863)
2023-11-21 andrewrkolos@gmail.com In `flutter doctor -v`, when JRE is too out-of-date to run `sdkmanager`, print a helpful error message (flutter/flutter#138762)
2023-11-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8e9b8dd562b to 7cf9d90d59e1 (1 revision) (flutter/flutter#138847)
2023-11-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90d1ff04ae02 to a8e9b8dd562b (1 revision) (flutter/flutter#138846)
2023-11-21 katelovett@google.com Reland VelocityTracker update (again) (flutter/flutter#138843)
2023-11-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31799868224d to 90d1ff04ae02 (2 revisions) (flutter/flutter#138844)
2023-11-21 tessertaha@gmail.com Fix M3 Tabs Specs links (flutter/flutter#138808)
2023-11-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c2de1e8849c to 31799868224d (1 revision) (flutter/flutter#138840)
2023-11-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 746697c27569 to 0c2de1e8849c (1 revision) (flutter/flutter#138834)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@andrewkolos @caseycrogers
In flutter doctor -v, when JRE is too out-of-date to run `sdkmanage…
3e94e18 
…r`, print a helpful error message (flutter#138762)

Closes flutter#138132. See this issue for more information.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
cf09a8a In flutter doctor -v, when JRE is too out-of-date to run `s…
6ba9a1a 
…dkmanager`, print a helpful error message (flutter/flutter#138762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter doctor --android-licenses fails on Command-line Tools 11.0

2 participants

@andrewkolos @christopherfujino