From 3fc3d3b2125be5777e92379a9f2cf047f86e65f8 Mon Sep 17 00:00:00 2001 From: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Date: Thu, 25 Mar 2021 20:05:27 +0100 Subject: [PATCH] Disable benchmarks test (#464) * Disable benchmarks test * Don't use MaterialIcons codepoints directly --- lib/data/icons.dart | 15 +++------------ test/benchmarks_test.dart | 3 +++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/data/icons.dart b/lib/data/icons.dart index 02e4c6ccb..ddf198f53 100644 --- a/lib/data/icons.dart +++ b/lib/data/icons.dart @@ -167,16 +167,7 @@ class GalleryIcons { 0xe927, fontFamily: 'GalleryIcons', ); - static const IconData navigationRail = IconData( - 60080, - fontFamily: 'MaterialIcons', - ); - static const IconData appbar = IconData( - 60134, - fontFamily: 'MaterialIcons', - ); - static const IconData divider = IconData( - 0xe8f0, - fontFamily: 'MaterialIcons', - ); + static const IconData navigationRail = Icons.vertical_split; + static const IconData appbar = Icons.web_asset; + static const IconData divider = Icons.credit_card; } diff --git a/test/benchmarks_test.dart b/test/benchmarks_test.dart index 93a8643c3..1e0ec710b 100644 --- a/test/benchmarks_test.dart +++ b/test/benchmarks_test.dart @@ -24,6 +24,9 @@ Future main() async { test('Can run a web benchmark', () async { print('Starting web benchmark tests ...'); + // TODO: re-enable this test (https://github.com/flutter/gallery/issues/463) + return; + // ignore: dead_code final taskResult = await serveWebBenchmark( benchmarkAppDirectory: projectRootDirectory(), entryPoint: 'test/benchmarks/client.dart',