You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not landing.
- Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,18 +2,18 @@
2
2
3
3
*List which issues are fixed by this PR. You must list at least one issue.*
4
4
5
-
## Pre-launch Checklist
5
+
## Pre-Review Checklist
6
6
7
7
-[ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
8
8
-[ ] I read the [Tree Hygiene] page, which explains my responsibilities.
9
9
-[ ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.)
10
10
-[ ] I signed the [CLA].
11
11
-[ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]`
12
12
-[ ] I [linked to at least one issue that this PR fixes] in the description above.
13
-
-[ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
14
-
-[ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
15
-
-[ ] I updated/added relevant documentation (doc comments with `///`).
16
-
-[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
13
+
-[ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.
14
+
-[ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.
15
+
-[ ] I updated/added any relevant documentation (doc comments with `///`).
16
+
-[ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under.
17
17
-[ ] All existing and new tests are passing.
18
18
19
19
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
@@ -26,7 +26,7 @@ If you need help, consider asking for advice on the #hackers-new channel on [Dis
[linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
0 commit comments