From ce74a85d7a95fd9f9499adf5ce2bf992e135f5f6 Mon Sep 17 00:00:00 2001 From: Eli Geller Date: Fri, 26 Apr 2024 00:52:43 +0300 Subject: [PATCH] [go_router] Update redirect documentation example code for clarity (#6213) The redirection documentation page gives an example where the top level redirect may be used to send non-signed-in users to the signin page. The example code seems to be doing so for signed in users, however. This is a documentation-only change. --- packages/go_router/CHANGELOG.md | 4 ++++ packages/go_router/doc/redirection.md | 2 +- packages/go_router/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/go_router/CHANGELOG.md b/packages/go_router/CHANGELOG.md index d38b99e530a3..1405fe78e380 100644 --- a/packages/go_router/CHANGELOG.md +++ b/packages/go_router/CHANGELOG.md @@ -1,3 +1,7 @@ +## 14.0.1 + +- Updates the redirection documentation for clarity + ## 14.0.0 - **BREAKING CHANGE** diff --git a/packages/go_router/doc/redirection.md b/packages/go_router/doc/redirection.md index e0ff022005a3..c8398e028ae5 100644 --- a/packages/go_router/doc/redirection.md +++ b/packages/go_router/doc/redirection.md @@ -10,7 +10,7 @@ either the GoRouter or GoRoute constructor: ```dart redirect: (BuildContext context, GoRouterState state) { - if (AuthState.of(context).isSignedIn) { + if (!AuthState.of(context).isSignedIn) { return '/signin'; } else { return null; diff --git a/packages/go_router/pubspec.yaml b/packages/go_router/pubspec.yaml index febb4db4ddbf..bd53a5f18a2e 100644 --- a/packages/go_router/pubspec.yaml +++ b/packages/go_router/pubspec.yaml @@ -1,7 +1,7 @@ name: go_router description: A declarative router for Flutter based on Navigation 2 supporting deep linking, data-driven routes and more -version: 14.0.0 +version: 14.0.1 repository: https://github.com/flutter/packages/tree/main/packages/go_router issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22