Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Standardize sourceCompatibility and targetCompatibility on the =` form of property assignment.

Part of flutter/flutter#176065

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Standardize `sourceCompatibility and targetCompatibility on the `=` form
of property assignment.

Part of flutter/flutter#176065
@stuartmorgan-g
Copy link
Collaborator Author

CHANGELOG/version override: this is a no-op style change, so doesn't impact clients.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the property assignment for sourceCompatibility and targetCompatibility in Gradle files across the repository, using the = syntax for consistency. The change is applied to numerous build.gradle files, and is also reflected in related documentation and validation scripts.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 27, 2025

autosubmit label was removed for flutter/packages/10091, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2025
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 27, 2025

autosubmit label was removed for flutter/packages/10091, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2025
@auto-submit auto-submit bot merged commit 002fa89 into flutter:main Sep 27, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 29, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 29, 2025
flutter/packages@389c678...34eec78

2025-09-29 blackorbs.dev@gmail.com [camera_android_camerax] Implement
setDescriptionWhileRecording (flutter/packages#10030)
2025-09-29 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#10114)
2025-09-27 stuartmorgan@google.com [various] Standardize Java compat in
Gradle (flutter/packages#10091)
2025-09-26 stuartmorgan@google.com [various] Standardize gradle
dependencies (flutter/packages#10083)
2025-09-26 paulberry@google.com [go_router_builder] Ignore upcoming
`experimental_member_use` warnings. (flutter/packages#10082)
2025-09-26 stuartmorgan@google.com [various] Standardize Gradle
`namespace` (flutter/packages#10084)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants