Skip to content

[pigeon] Consolidate platform test harnesses part 3.1 - iOS Swift #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

[pigeon] Consolidate platform test harnesses part 3.1 - iOS Swift #2815

merged 1 commit into from
Nov 16, 2022

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Nov 16, 2022

Part of #2803; see also #2811

Moves the Swift iOS tests into the new combined harnesses, updating the test script accordingly and removing the old harness.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g added override: allow breaking change Override the check preventing breaking changes to platform interfaces override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes and removed override: allow breaking change Override the check preventing breaking changes to platform interfaces labels Nov 16, 2022
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 16, 2022

auto label is removed for flutter/packages, pr: 2815, Failed to merge pr#: 2815 with Pull request could not be merged: Resource not accessible by integration.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Nov 16, 2022

Resource not accessible by integration.

No idea what that means... trying manual landing.

@stuartmorgan-g stuartmorgan-g merged commit bb1c9dc into flutter:main Nov 16, 2022
@stuartmorgan-g stuartmorgan-g deleted the pigeon-test-harness-consolidation-ios-swift branch November 16, 2022 19:35
@ricardoamador ricardoamador mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees

No one assigned

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g @tarrinneal