Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable tests on stable #886

Merged
merged 2 commits into from
Feb 18, 2022
Merged

[ci] Enable tests on stable #886

merged 2 commits into from
Feb 18, 2022

Conversation

stuartmorgan
Copy link
Contributor

In general, packages should support the latest stable as well as master,
so tests should be run against both versions.

Fixes flutter/flutter#97233

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[ci] Enable tests on stable
aba4d1a 
In general, packages should support the latest stable as well as master,
so tests should be run against both versions.
@stuartmorgan stuartmorgan marked this pull request as draft February 17, 2022 20:59
@stuartmorgan stuartmorgan marked this pull request as ready for review February 18, 2022 16:02
@stuartmorgan stuartmorgan mentioned this pull request Feb 18, 2022
Merged
Hixie
Hixie approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit cd24089 into flutter:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
waiting for tree to go green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[packages] Run unit tests on stable as well
3 participants
@stuartmorgan @Hixie @fluttergithubbot