[rfw] Run tests for package:rfw on stable as well. #888
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
See also #886, where I'm turning on the missing unit tests on stable, but had to exclude rfw because of goldens. I don't know if you want to do something more clever within the rfw tests themselves to only exclude the goldens? |
- print('Tests passed. (Coverage verification skipped; not on master channel.)');
+ print(
+ 'Tests passed. (Coverage verification skipped; not on master channel.)'); |
any idea why the tests didn't fail? i didn't do anything to avoid stable for the goldens... |
I did, it's just ugly: |
|
right but that hasn't landed yet, right? so why did my precommits not fail? |
|
Oh, your precommits are fine because of flutter/flutter#97233 (which is why my PR is fixing). |
|
oh, haha. Ok let me figure out some way to skip the tests properly. in the meantime feel free to land 866. |
For non-master-channel builds, the run_tests.sh script runs but doesn't bother checking the actual coverage, since I expect Dart's coverage logic to diverge in master and so we'd have to have per-channel covered line counts, and that way lies madness. No version change: Only affects how tests are run, not a public-facing change. No CHANGELOG change: Only affects how tests are run, not a public-facing change.
|
@stuartmorgan PTAL |
| exit(1); | ||
| } | ||
|
|
||
| if (Platform.environment['CHANNEL'] != 'master') { |
There was a problem hiding this comment.
Did you want the "no channel set" condition here as well for local runs?
|
@Hixie Is this waiting on something to land? |
|
Sorry, other efforts took my attention away from my PRs. I'll return to them in due course. Feel free to land this for me in the meantime if you want (looks like it'll need merging first). |
For non-master-channel builds, the run_tests.sh script runs but
doesn't bother checking the actual coverage, since I expect Dart's
coverage logic to diverge in master and so we'd have to have
per-channel covered line counts, and that way lies madness.
No version change: Only affects how tests are run, not a public-facing change.
No CHANGELOG change: Only affects how tests are run, not a public-facing change.