[interactive_media_ads] Fixes support for ad tag URLs that do not contain a query #9176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
stuartmorgan-g
approved these changes
May 7, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one type safety suggestion.
We could in theory append ?... rather than nothing in this case, but we can wait and see if there are any cases where we actually know servers would do anything with that.
| "\(adTagUrl)&request_agent=Flutter-IMA-\(AdsRequestProxyAPIDelegate.pluginVersion)" | ||
| return IMAAdsRequest( | ||
| adTagUrl: adTagWithRequestAgent, adDisplayContainer: adDisplayContainer, | ||
| adTagUrl: modifiedURL!, adDisplayContainer: adDisplayContainer, |
Collaborator
There was a problem hiding this comment.
Rather than force-unwrapping, you could assign with a ternary, giving better type safety.
let modifiedURL = !adTagUrl.contains("#") && adTagUrl.contains("?")
? ...
: adTagUrl
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2025
…do not contain a query (flutter/packages#9176)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 8, 2025
flutter/packages@b2ce3b0...ab44c26 2025-05-08 31216074+gentlemanxzh@users.noreply.github.com [google_maps_flutter] Fix for memory leak impacting all platforms due to subscriptions not getting cleaned up (flutter/packages#8972) 2025-05-08 engine-flutter-autoroll@skia.org Roll Flutter from cfb887c to b0f5c8c (281 revisions) (flutter/packages#9223) 2025-05-08 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes support for ad tag URLs that do not contain a query (flutter/packages#9176) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…tain a query (flutter#9176) Fixes flutter/flutter#166453 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…tain a query (flutter#9176) Fixes flutter/flutter#166453 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…tain a query (flutter#9176) Fixes flutter/flutter#166453 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#166453
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3