Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 0e4c188

Browse files
committed
upgraded usage of BinaryMessenger
1 parent c85fa03 commit 0e4c188

File tree

4 files changed

+17
-12
lines changed

4 files changed

+17
-12
lines changed

packages/android_intent/android/src/test/java/io/flutter/plugins/androidintent/MethodCallHandlerImplTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void startListening_registersChannel() {
5555
methodCallHandler.startListening(messenger);
5656

5757
verify(messenger, times(1))
58-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
58+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
5959
}
6060

6161
@Test
@@ -67,9 +67,9 @@ public void startListening_unregistersExistingChannel() {
6767
methodCallHandler.startListening(secondMessenger);
6868

6969
// Unregisters the first and then registers the second.
70-
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
70+
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
7171
verify(secondMessenger, times(1))
72-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
72+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
7373
}
7474

7575
@Test
@@ -79,7 +79,7 @@ public void stopListening_unregistersExistingChannel() {
7979

8080
methodCallHandler.stopListening();
8181

82-
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
82+
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
8383
}
8484

8585
@Test
@@ -88,7 +88,7 @@ public void stopListening_doesNothingWhenUnset() {
8888

8989
methodCallHandler.stopListening();
9090

91-
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null);
91+
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null, null);
9292
}
9393

9494
@Test

packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
import android.os.Handler;
1414
import androidx.annotation.NonNull;
15+
import androidx.annotation.Nullable;
1516
import io.flutter.embedding.engine.systemchannels.PlatformChannel;
1617
import io.flutter.plugin.common.BinaryMessenger;
1718
import io.flutter.plugin.common.MethodCall;
@@ -42,7 +43,8 @@ public void send(@NonNull String channel, ByteBuffer message, BinaryReply callba
4243
}
4344

4445
@Override
45-
public void setMessageHandler(@NonNull String channel, BinaryMessageHandler handler) {}
46+
public void setMessageHandler(
47+
@NonNull String channel, BinaryMessageHandler handler, @Nullable TaskQueue taskQueue) {}
4648

4749
List<ByteBuffer> getMessages() {
4850
return new ArrayList<>(sentMessages);

packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ public void send(
5050
}
5151

5252
@Override
53-
public void setMessageHandler(@NonNull String channel, @Nullable BinaryMessageHandler handler) {
53+
public void setMessageHandler(
54+
@NonNull String channel,
55+
@Nullable BinaryMessageHandler handler,
56+
@Nullable TaskQueue taskQueue) {
5457
// Do nothing.
5558
}
5659
}

packages/url_launcher/url_launcher/android/src/test/java/io/flutter/plugins/urllauncher/MethodCallHandlerImplTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void startListening_registersChannel() {
4444
methodCallHandler.startListening(messenger);
4545

4646
verify(messenger, times(1))
47-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
47+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
4848
}
4949

5050
@Test
@@ -56,9 +56,9 @@ public void startListening_unregistersExistingChannel() {
5656
methodCallHandler.startListening(secondMessenger);
5757

5858
// Unregisters the first and then registers the second.
59-
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
59+
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
6060
verify(secondMessenger, times(1))
61-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
61+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
6262
}
6363

6464
@Test
@@ -68,7 +68,7 @@ public void stopListening_unregistersExistingChannel() {
6868

6969
methodCallHandler.stopListening();
7070

71-
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
71+
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
7272
}
7373

7474
@Test
@@ -77,7 +77,7 @@ public void stopListening_doesNothingWhenUnset() {
7777

7878
methodCallHandler.stopListening();
7979

80-
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null);
80+
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null, null);
8181
}
8282

8383
@Test

0 commit comments

Comments
 (0)