Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit e615682

Browse files
authored
[google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized clientId (#3686)
1 parent 26879db commit e615682

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.0.1
2+
3+
* Updates `init` function in `MethodChannelGoogleSignIn` to parametrize `clientId` property.
4+
15
## 2.0.0
26

37
* Migrate to null-safety.

packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform {
3030
'signInOption': signInOption.toString(),
3131
'scopes': scopes,
3232
'hostedDomain': hostedDomain,
33+
'clientId': clientId,
3334
});
3435
}
3536

packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: A common platform interface for the google_sign_in plugin.
33
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface
44
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
55
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
6-
version: 2.0.0
6+
version: 2.0.1
77

88
dependencies:
99
flutter:

packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,12 @@ void main() {
100100
hostedDomain: 'example.com',
101101
scopes: <String>['two', 'scopes'],
102102
signInOption: SignInOption.games,
103-
clientId: 'UNUSED!');
103+
clientId: 'fakeClientId');
104104
}: isMethodCall('init', arguments: <String, dynamic>{
105105
'hostedDomain': 'example.com',
106106
'scopes': <String>['two', 'scopes'],
107107
'signInOption': 'SignInOption.games',
108+
'clientId': 'fakeClientId',
108109
}),
109110
() {
110111
googleSignIn.getTokens(

0 commit comments

Comments
 (0)