[In_app_purchases] migrate to Play Billing Library 2.0. #2287

cyanglaz · 2019-11-19T18:26:59Z

Description

This PR migrates the IAP plugin to BillingClient 2.0 on Android.
It contains changes described below:

     * Introduce a new class `BillingResultWrapper` which contains a detailed result of a BillingClient operation.
          * **[Breaking Change]:**  All the BillingClient methods that previously return a `BillingResponse` now return a `BillingResultWrapper`, including: `launchBillingFlow`, `startConnection` and `consumeAsync`.
          * **[Breaking Change]:**  The `SkuDetailsResponseWrapper` now contains a `billingResult` field in place of `billingResponse` field.
          * A `billingResult` field is added to the `PurchasesResultWrapper`.
     * Other Updates to the "billing_client_wrappers":
          * Updates to the `PurchaseWrapper`: Add `developerPayload`, `purchaseState` and `isAcknowledged` fields.
          * Updates to the `SkuDetailsWrapper`: Add `originalPrice` and `originalPriceAmountMicros` fields.
          * **[Breaking Change]:** The `BillingClient.queryPurchaseHistory` is updated to return a `PurchasesHistoryResult`, which contains a list of `PurchaseHistoryRecordWrapper` instead of `PurchaseWrapper`. A `PurchaseHistoryRecordWrapper` object has the same fields and values as A `PurchaseWrapper` object, except that a `PurchaseHistoryRecordWrapper` object does not contain `isAutoRenewing`, `orderId` and `packageName`.
          * Add a new `BillingClient.acknowledgePurchase` API. Starting from this version, the developer has to acknowledge any purchase on Android using this API within 3 days of purchase, or the user will be refunded. Note that if a product is "consumed", it is implicitly acknowledged.
          * **[Breaking Change]:**  Added `enablePendingPurchases` in `BillingClientWrapper`. The application has to call this method before calling `BillingClientWrapper.startConnection`. See [enablePendingPurchases](https://developer.android.com/reference/com/android/billingclient/api/BillingClient.Builder.html#enablependingpurchases) for more information.
     * Updates to the "InAppPurchaseConnection":
          * **[Breaking Change]:** `InAppPurchaseConnection.completePurchase` now returns a `Future<BillingResultWrapper>` instead of `Future<void>`. A new optional parameter `{String developerPayload}` has also been added to the API. On Android, this API does not throw an exception anymore, it instead acknowledge the purchase.
          * **[Breaking Change]:** `InAppPurchaseConnection.consumePurchase` now returns a `Future<BillingResultWrapper>` instead of `Future<BillingResponse>`. A new optional parameter `{String developerPayload}` has also been added to the API.
          * A new boolean field `pendingCompletePurchase` has been added to the `PurchaseDetails` class. Which can be used as an indicator of whether to call `InAppPurchaseConnection.completePurchase` on the purchase.
          * **[Breaking Change]:**  Added `enablePendingPurchases` in `InAppPurchaseConnection`. The application has to call this method when initializing the `InAppPurchaseConnection` on Android. See [enablePendingPurchases](https://developer.android.com/reference/com/android/billingclient/api/BillingClient.Builder.html#enablependingpurchases) for more information.
     * Misc: Some documentation updates reflecting the `BillingClient` migration and some documentation fixes.
     * Refer to [Google Play Billing Library Release Note](https://developer.android.com/google/play/billing/billing_library_releases_notes#release-2_0) for a detailed information on the update.

This PR also contains some documentation updates based on the BillingClient v2 changes.

Link to the BillingClient v2 release note: https://developer.android.com/google/play/billing/billing_library_releases_notes#release-2_0

IMPORTANT a breaking change announcement following the breaking change protocol has to be made prior to landing this PR
The desgin doc including all the public API change details can be found here:
https://docs.google.com/document/d/1XM16UsLE_aPWoZnheE9waO06mhxLkkWjpPf9jtI1AdY/edit?usp=sharing

Related Issues

flutter/flutter#37021

flutter/flutter#37821 and flutter/flutter#40956 should also be fixed since enablePendingPurchases() is called by default after this change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

packages/in_app_purchase/CHANGELOG.md

mklim · 2019-11-19T20:32:19Z

...urchase/android/src/main/java/io/flutter/plugins/inapppurchase/BillingClientFactoryImpl.java

@@ -14,6 +14,7 @@
  @Override
  public BillingClient createBillingClient(Context context, MethodChannel channel) {
    return BillingClient.newBuilder(context)
+        .enablePendingPurchases()


As far as I can tell this API exists on the PBL2 SDK just to make sure that the developer has really read the new API docs and is aware of the need to register pending purchase changes. I think we should also gate this breaking change behind something similar, though I'm not totally sure as to what. Some people use package: any dependencies in their pubspec and will just automatically get this. I think it may be good to have some kind of obvious hard failure that makes it basically impossible to miss the new changes. I'm not sure if requiring people to effectively set a param or call this is the right way to go here, but I'm considering it. WDYT?

We can guard this by asking BillingClient on dart to call an API with the same name enablePendingPurchases (), otherwise do an assertion failure. Although we can fail it on dart side, I think we should always call it on the JAVA side.
On the unified layer, we can either do the same, or hide it from the user. WDYT?

I'm going to reach out offline to get some second opinions on this.

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

mklim · 2019-11-22T18:44:53Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+      if (status == PurchaseStatus.purchased ||
+          status == PurchaseStatus.error) {
+        pendingCompletePurchase = true;
+      }
+    }
+    if (_platform == _kPlatformAndroid) {
+      if (status == PurchaseStatus.purchased) {


So does the user need to special case whether or not they call completePurchase based on what the status is and whether they're on iOS or Android now, where with Android they should avoid calling it for PurchaseStatus.error? I think this should probably be mentioned in the completePurchase docs.

see the response on https://github.com/flutter/plugins/pull/2287/files#r349738652

Sorry, that link doesn't work anymore. I think the PR may be too big. Do you mind copy/pasting it?

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

mklim · 2019-11-22T18:47:44Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+        this.billingClientPurchase = null {
+    this.status = SKTransactionStatusConverter()
+        .toPurchaseStatus(transaction.transactionState);
+    _platform = _kPlatformIOS;


nit: I think this can go outside of the method block with the other variables that are set above it. Same with the Android one below.

nit: I think _platform can also be set the same way here and below.

cyanglaz

Updated the most of the comments.
For some documentation changes, will need to confirm and update it in another patch.

...xample/android/app/src/test/java/io/flutter/plugins/inapppurchase/MethodCallHandlerTest.java

...chase/example/android/app/src/test/java/io/flutter/plugins/inapppurchase/TranslatorTest.java

packages/in_app_purchase/example/lib/main.dart

packages/in_app_purchase/lib/src/billing_client_wrappers/purchase_wrapper.dart

packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

cyanglaz · 2019-11-25T17:49:50Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+      if (status == PurchaseStatus.purchased ||
+          status == PurchaseStatus.error) {
+        pendingCompletePurchase = true;
+      }
+    }
+    if (_platform == _kPlatformAndroid) {
+      if (status == PurchaseStatus.purchased) {


see the response on https://github.com/flutter/plugins/pull/2287/files#r349738652

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

cyanglaz · 2019-11-25T17:54:56Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+        this.billingClientPurchase = null {
+    this.status = SKTransactionStatusConverter()
+        .toPurchaseStatus(transaction.transactionState);
+    _platform = _kPlatformIOS;


mklim · 2019-12-03T23:37:47Z

...chase/example/android/app/src/test/java/io/flutter/plugins/inapppurchase/TranslatorTest.java

@@ -158,6 +158,16 @@ public void fromBillingResult() throws JSONException {
    assertEquals(billingResultMap.get("debugMessage"), newBillingResult.getDebugMessage());
  }

+  @Test
+  public void fromBillingResult_dubugMessageNull() throws JSONException {


nit:

Suggested change

public void fromBillingResult_dubugMessageNull() throws JSONException {

public void fromBillingResult_debugMessageNull() throws JSONException {

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

mklim · 2019-12-03T23:47:13Z

packages/in_app_purchase/lib/src/billing_client_wrappers/enum_converters.dart

-///
-/// Use these in `@JsonSerializable()` classes by annotating them with
-/// `@BillingResponseConverter()`.
+// Use these in `@JsonSerializable()` classes by annotating them with


nit: Why deleting the paragraph breaks here and below? I think they probably made sense as-is.

mklim · 2019-12-03T23:53:21Z

packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart

+    if (purchase.billingClientPurchase.isAcknowledged) {
+      return BillingResultWrapper(responseCode: BillingResponse.ok);
+    }
+    return await billingClient.acknowledgePurchase(
+        purchase.verificationData.serverVerificationData,
        developerPayload: developerPayload);


This is a nice thing to have for the developer in case they accidentally call this twice, but I would rather just defer to the underlying SDK at all times here instead of trying to special case based off of what we think the state of this purchase really is. I don't want to risk introducing any bugs based on our state being somehow out of sync with the reality on the platform.

packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart

mklim · 2019-12-04T00:00:40Z

packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

  ///
-  /// Warning!Fail to call this method within 3 days of the purchase will result a refund on Android.
+  /// Warning!Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.


nit:

Suggested change

/// Warning!Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.

/// Warning! Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.

mklim · 2019-12-04T00:02:41Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+        this.billingClientPurchase = null {
+    this.status = SKTransactionStatusConverter()
+        .toPurchaseStatus(transaction.transactionState);
+    _platform = _kPlatformIOS;


nit: I think _platform can also be set the same way here and below.

packages/in_app_purchase/lib/src/billing_client_wrappers/purchase_wrapper.dart

mklim · 2019-12-04T00:13:26Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+      if (status == PurchaseStatus.purchased ||
+          status == PurchaseStatus.error) {
+        pendingCompletePurchase = true;
+      }
+    }
+    if (_platform == _kPlatformAndroid) {
+      if (status == PurchaseStatus.purchased) {


Sorry, that link doesn't work anymore. I think the PR may be too big. Do you mind copy/pasting it?

mklim · 2019-12-04T00:21:25Z

...urchase/android/src/main/java/io/flutter/plugins/inapppurchase/BillingClientFactoryImpl.java

@@ -14,6 +14,7 @@
  @Override
  public BillingClient createBillingClient(Context context, MethodChannel channel) {
    return BillingClient.newBuilder(context)
+        .enablePendingPurchases()


I'm going to reach out offline to get some second opinions on this.

cyanglaz

Updated with suggestions. Waiting on enablePendingPurchases API decision.

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

cyanglaz · 2019-12-04T20:40:31Z

packages/in_app_purchase/lib/src/billing_client_wrappers/enum_converters.dart

-///
-/// Use these in `@JsonSerializable()` classes by annotating them with
-/// `@BillingResponseConverter()`.
+// Use these in `@JsonSerializable()` classes by annotating them with


cyanglaz · 2019-12-04T20:44:43Z

packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

  ///
-  /// Warning!Fail to call this method within 3 days of the purchase will result a refund on Android.
+  /// Warning!Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.


packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart

cyanglaz · 2019-12-04T20:48:31Z

packages/in_app_purchase/lib/src/in_app_purchase/purchase_details.dart

+        this.billingClientPurchase = null {
+    this.status = SKTransactionStatusConverter()
+        .toPurchaseStatus(transaction.transactionState);
+    _platform = _kPlatformIOS;


mklim

Everything here LG pending the enablePendingPurchases question.

Small nit, looks like some new analyzer failures:

info - Don't explicitly initialize variables to null at lib/src/in_app_purchase/in_app_purchase_connection.dart:193:8 - (avoid_init_to_null)
info - Don't explicitly initialize variables to null at lib/src/in_app_purchase/in_app_purchase_connection.dart:205:8 - (avoid_init_to_null)

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

mklim · 2019-12-05T23:41:23Z

Everything here LG pending the enablePendingPurchases question.

Came to a decision offline. We'd like to expose the enablePendingPurchase API in both the Play and unified API layers in the plugin. However we'll make the iOS instance of the unified implementation of the API a no-op and not cause any issues if it's not called when running on iOS.

cyanglaz · 2019-12-07T00:08:43Z

@mklim Added a draft of the new pendingPurchaseAPI, do you want to take a look and see how you like it?

mklim

LGTM!

nit: it looks like the unit tests are failing and need to be updated.

mklim · 2019-12-09T18:06:13Z

packages/in_app_purchase/CHANGELOG.md

@@ -1,6 +1,8 @@
 ## 0.3.0

 * Migrate the `Google Play Library` to 2.0.3.
+     * **[Breaking Change]:**  Added `enablePendingPurchases` in `InAppPurchaseConnection`. The application has


nit: I think a link to the Play documentation on enablePendingPurchases would be useful here.

mklim · 2019-12-09T18:12:54Z

packages/in_app_purchase/example/lib/main.dart

@@ -9,6 +9,7 @@ import 'package:in_app_purchase/in_app_purchase.dart';
 import 'consumable_store.dart';

 void main() {
+  InAppPurchaseConnection.enablePendingPurchases();


nit: Comment here explaining what this is and linking to the Play documentation would be useful.

mklim · 2019-12-09T18:14:27Z

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

@@ -71,6 +73,17 @@ class BillingClient {
  Future<bool> isReady() async =>
      await channel.invokeMethod<bool>('BillingClient#isReady()');

+  /// Enable the [BillingClientWrapper] to handle pending purchases.
+  ///
+  /// This method is required to be called when initialize the application.


Small optional wording nit:

Suggested change

/// This method is required to be called when initialize the application.

/// Play requires that you call this method when initializing your application.

https://developers.google.com/style/voice

mklim · 2019-12-09T18:14:59Z

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart

+  /// This method is required to be called when initialize the application.
+  /// It is to acknowledge your application has been updated to support pending purchases.
+  /// See [Support pending transactions](https://developer.android.com/google/play/billing/billing_library_overview#pending)
+  /// for more details.


nit: paragraph break below would make sense, I think.

cyanglaz · 2019-12-26T17:30:59Z

Offline discussion with @amirh. Because the overhead of a 2-phase* release for this breaking change is very big and the usage of the plugin is low. We've decided to let this change to be a 1-phase* update. The breaking changes will be described in the CHANGELOG.

2-phase: introduce a minor update while deprecating the old methods, then follow up with a major update which delete the deprecated methods. In this particular case, it is hard to do since we will need to mock many functionalities without updating Android's Play Billing Library to 2.0, which can result unwanted behaviors and confusions.

1-phase: directly introduce a major update with all the breakages.

amirh · 2020-01-06T18:55:51Z

Offline discussion with @amirh. Because the overhead of a 2-phase* release for this breaking change is very big and the usage of the plugin is low. We've decided to let this change to be a 1-phase* update. The breaking changes will be described in the CHANGELOG.

2-phase: introduce a minor update while deprecating the old methods, then follow up with a major update which delete the deprecated methods. In this particular case, it is hard to do since we will need to mock many functionalities without updating Android's Play Billing Library to 2.0, which can result unwanted behaviors and confusions.

1-phase: directly introduce a major update with all the breakages.

LGTM to land this without a deprecation phase, since the platform library didn't land their breaking change with a deprecation doing so in our side is complex and potentially error prone, and as the plugin is still relatively new we expect the ecosystem impact to not be too wide.

…acheing-01-08 * flutterPlugin/master: (30 commits) Update Gradle version (flutter#2448) [image_picker] support android V2 embedding (flutter#2430) [webview_flutter] Setup XCTests (flutter#2445) [video_player] Fixes video initialization future stall. (flutter#2134) [ci] Upgrade to Xcode 11.3 (flutter#2435) [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287) Migrate away from deprecated `BinaryMessages` (flutter#2444) [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335) [ios_platform_images] Removed android support from the pubspec. (flutter#2432) [google_sign_in] Expose network error (flutter#2398) [battery] cleanup for Android embedding post 1.12 (flutter#2400) [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) re-enable stable CI (flutter#2402) [in_app_purchase]Change a comment. (flutter#2329) [google_sign_in] Pass the client id to the platform interface. (flutter#2427) [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414) [url_launcher_platform_interface] use non static token for platform interface (flutter#2418) [plugin_platform_interface] Don't use const Object as a token (flutter#2417) Update endorsed macos plugins readme and update others (flutter#2407) [webview_flutter] add gesture navigation for iOS (flutter#2339) ... # Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml

malsabbagh · 2020-01-21T05:16:08Z

packages/in_app_purchase/example/lib/main.dart

@@ -361,28 +365,32 @@ class _MyAppState extends State<MyApp> {

  void _listenToPurchaseUpdated(List<PurchaseDetails> purchaseDetailsList) {
    purchaseDetailsList.forEach((PurchaseDetails purchaseDetails) async {
+      await InAppPurchaseConnection.instance.consumePurchase(purchaseDetails);


consumePurchase is only for Play Store. This line should not be here when running on iOS or during error case as you won't be able to consume the purchaseDetails

Good catch! This was added for a manual testing. It shouldn't be here.

malsabbagh · 2020-01-21T05:37:05Z

packages/in_app_purchase/example/lib/main.dart

      if (purchaseDetails.status == PurchaseStatus.pending) {
        showPendingUI();
      } else {
        if (purchaseDetails.status == PurchaseStatus.error) {
          handleError(purchaseDetails.error);
+          return;


Also on iOS completePurchase() needs to be called for status == PurchaseStatus.error. With this change this will be broken.

Please refer to completePurchase documentation.

plugins/packages/in_app_purchase/lib/src/in_app_purchase/in_app_purchase_connection.dart

Line 197 in ed7620c

/// the purchase needs to be completed if the [PurchaseDetails.status] is [PurchaseStatus.error].

malsabbagh · 2020-01-21T05:42:43Z

packages/in_app_purchase/example/lib/main.dart

        } else if (purchaseDetails.status == PurchaseStatus.purchased) {
          bool valid = await _verifyPurchase(purchaseDetails);
          if (valid) {
            deliverProduct(purchaseDetails);
          } else {
            _handleInvalidPurchase(purchaseDetails);
+            return;


I am guessing this will have the same impact as line 374.

cyanglaz · 2020-01-21T20:04:47Z

@malsabbagh Thanks for the review. Do you mind putting up a PR to fix those? :)

malsabbagh · 2020-01-22T14:34:52Z

@cyanglaz sure I am happy to do it :)

cyanglaz · 2020-01-22T17:35:31Z

@malsabbagh That's great! Please ping me in the PR once you open it, I will be happy to review it!

cyanglaz requested a review from mklim as a code owner November 19, 2019 18:26

googlebot added the cla: yes label Nov 19, 2019

cyanglaz requested a review from amirh November 19, 2019 18:27

migrate to play library 2.0

e4c9796

cyanglaz changed the title ~~[In_app_purchases] migrate to billing client 2.0.~~ [In_app_purchases] migrate to Play Billing Library 2.0. Nov 19, 2019

cyanglaz force-pushed the iap_v2 branch from 0de4191 to e4c9796 Compare November 19, 2019 18:29

fix ci

d47ae9c

mklim reviewed Nov 22, 2019

View reviewed changes

cyanglaz commented Nov 25, 2019

View reviewed changes

Chris Yang and others added 5 commits November 25, 2019 09:59

review fixes

a10b0ea

some cleanup

7fec09a

fix analyzer warning

1d41afc

Merge branch 'master' into iap_v2

4549dc0

review updates

37df4a4

mklim reviewed Dec 4, 2019

View reviewed changes

cyanglaz commented Dec 4, 2019

View reviewed changes

Chris Yang added 2 commits December 4, 2019 12:50

review fixes

b0b69e5

merge master

4959ffb

mklim reviewed Dec 4, 2019

View reviewed changes

packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart Show resolved Hide resolved

Chris Yang added 4 commits December 6, 2019 11:45

merge master and fix analyzer error

a44756f

fix test

fb8655e

add pending purchase api

e815b17

formatting

61c5771

mklim approved these changes Dec 9, 2019

View reviewed changes

Chris Yang added 4 commits December 11, 2019 10:09

review comments fix

d63cc13

merge master

3b3c67e

fix test for enablependingpurchases and formatting

e610421

add missing breaking change in CHANGELOG

a3239f7

Chris Yang added 4 commits December 23, 2019 14:58

addfltp

215086f

fix tests

33576c7

formatting

a3a576c

update CHANGELOG

6f2c821

cyanglaz merged commit ed7620c into flutter:master Jan 6, 2020

cyanglaz deleted the iap_v2 branch January 6, 2020 18:58

cyanglaz mentioned this pull request Jan 6, 2020

Update the In App Purchase plugin to use Play Billing Library 2 flutter/flutter#37021

Closed

d0bry mentioned this pull request Jan 19, 2020

[in_app_purchase] Android: purchaseDetails.pendingCompletePurchase is always false flutter/flutter#49083

Closed

malsabbagh reviewed Jan 21, 2020

View reviewed changes

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287)

d7f38f2

	public void fromBillingResult_dubugMessageNull() throws JSONException {
	public void fromBillingResult_debugMessageNull() throws JSONException {

	/// Warning!Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.
	/// Warning! Failure to call this method and get a successful response within 3 days of the purchase will result a refund on Android.

	/// This method is required to be called when initialize the application.
	/// Play requires that you call this method when initializing your application.

[In_app_purchases] migrate to Play Billing Library 2.0. #2287

[In_app_purchases] migrate to Play Billing Library 2.0. #2287

Conversation

cyanglaz commented Nov 19, 2019 • edited Loading

Description

Related Issues

Checklist

Breaking Change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mklim left a comment

Choose a reason for hiding this comment

mklim commented Dec 5, 2019

cyanglaz commented Dec 7, 2019

mklim left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz commented Dec 26, 2019 • edited Loading

amirh commented Jan 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malsabbagh Jan 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz commented Jan 21, 2020

malsabbagh commented Jan 22, 2020

cyanglaz commented Jan 22, 2020

cyanglaz commented Nov 19, 2019 •

edited

Loading

mklim left a comment •

edited

Loading

cyanglaz commented Dec 26, 2019 •

edited

Loading

malsabbagh Jan 21, 2020 •

edited

Loading