This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ios_platform_images] Made ios_platform_images set the correct image scale. #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Collin Jackson <jackson@google.com>
Co-Authored-By: Collin Jackson <jackson@google.com>
collinjackson
approved these changes
Dec 13, 2019
| /// Performs exactly like a [MemoryImage] but instead of taking in bytes it takes | ||
| /// in a future that represents bytes. | ||
| class FutureMemoryImage extends ImageProvider<FutureMemoryImage> { | ||
| class _FutureMemoryImage extends ImageProvider<_FutureMemoryImage> { | ||
| /// Constructor for FutureMemoryImage. [_futureBytes] is the bytes that will |
There was a problem hiding this comment.
Since this class is private you probably don't need dartdoc comments here.
If you do feel compelled to document _futureBytes and _futureScale you should do that where they're defined. (First Dartdoc paragraph should always be a single sentence.)
There was a problem hiding this comment.
I already went through the trouble documenting it. I know they aren't required now, but they are still useful.
| @@ -1,4 +1,8 @@ | |||
| ## 0.0.2 | |||
There was a problem hiding this comment.
Should be 0.1.0 since you're removing a class.
sanekyy
pushed a commit
to sanekyy/plugins
that referenced
this pull request
Dec 21, 2019
hjc22
pushed a commit
to hjc22/plugins
that referenced
this pull request
Jan 8, 2020
…acheing-01-08 * flutterPlugin/master: (30 commits) Update Gradle version (flutter#2448) [image_picker] support android V2 embedding (flutter#2430) [webview_flutter] Setup XCTests (flutter#2445) [video_player] Fixes video initialization future stall. (flutter#2134) [ci] Upgrade to Xcode 11.3 (flutter#2435) [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287) Migrate away from deprecated `BinaryMessages` (flutter#2444) [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335) [ios_platform_images] Removed android support from the pubspec. (flutter#2432) [google_sign_in] Expose network error (flutter#2398) [battery] cleanup for Android embedding post 1.12 (flutter#2400) [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) re-enable stable CI (flutter#2402) [in_app_purchase]Change a comment. (flutter#2329) [google_sign_in] Pass the client id to the platform interface. (flutter#2427) [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414) [url_launcher_platform_interface] use non static token for platform interface (flutter#2418) [plugin_platform_interface] Don't use const Object as a token (flutter#2417) Update endorsed macos plugins readme and update others (flutter#2407) [webview_flutter] add gesture navigation for iOS (flutter#2339) ... # Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where ios_platform_images wouldn't load images at different scales correctly.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?