Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_webview] Raise min Flutter SDK to stable #2425

Merged
merged 3 commits into from
Dec 18, 2019
Merged

[flutter_webview] Raise min Flutter SDK to stable #2425

merged 3 commits into from
Dec 18, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Dec 16, 2019 •
edited
Loading

Description

v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.

Related Issues

flutter/flutter#47153
flutter/flutter#42348
flutter/flutter#42694

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mklim mklim requested a review from amirh December 16, 2019 21:06
@mklim mklim mentioned this pull request Dec 16, 2019
Closed
33 tasks
@ened
Copy link
Contributor

ened commented Dec 17, 2019

@mklim Do you think major SDK bumps warrant a major version bump (e.g. 0.4.0)

@xster
Copy link
Member

xster commented Dec 17, 2019

A few more things we should probably do flutter/flutter#47153 (comment)

@mklim
Copy link
Contributor Author

mklim commented Dec 17, 2019

@ened I was wondering that too. The semver spec says no:

Software that explicitly depends on the same dependencies as your package should have their own dependency specifications and the author will notice any conflicts. Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. I would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.

Since pub should be resolving Flutter SDK dependencies normally I think it makes sense to follow semver here.

All the actual changes in this amount to internal refactoring so I kept it as a patch bump.

@xster good catch, marking this as a WIP until I resolve those other steps.

@mklim mklim added the WIP label Dec 17, 2019
[flutter_webview] Raise min Flutter SDK to stable
d6a17a9 
v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.
@mklim mklim mentioned this pull request Dec 17, 2019
Closed
@mklim mklim removed the WIP label Dec 17, 2019
@mklim
Copy link
Contributor Author

mklim commented Dec 17, 2019

OK, this should be ready for review now.

amirh
amirh approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim
Copy link
Contributor Author

mklim commented Dec 17, 2019

FWIW, Emmanuel makes a valid point in #2400. If you merge this now, people on 1.9 stable will break.

Sorry, I can't find a comment about this there. @blasten or @xster do you mind copy pasting it?

I don't think this should break anyone on 1.9, because it's bumping the minimum Flutter SDK version in the pubspec.yaml to 1.12. Anyone on 1.9 shouldn't be able to get this version of the plugin because pub will be able to tell that their Flutter SDK version is too low.

@xster
Copy link
Member

xster commented Dec 17, 2019

ya I deleted the comment and hoped it's forever erased from everyone's memory after typing it and realizing that it's no long valid since we moved the sdk restriction up :)

@mklim
Copy link
Contributor Author

mklim commented Dec 18, 2019

Lol all good, thanks. :)

@mklim mklim merged commit 2be4c80 into flutter:master Dec 18, 2019
@mklim mklim deleted the flutter_webview_latest_stable branch December 18, 2019 00:06
eugenejeonme added a commit to COMANDKEYINC/flutter_plugins that referenced this pull request Dec 19, 2019
@eugenejeonme
Archive/20191219 (#4)
c6333a6 
* [google_sign_in] Pass the client id to the platform interface. (flutter#2427)

The param exists in the platform interface but there was no way to pass
anything to clientId through the external interface.

* [in_app_purchase]Change a comment. (flutter#2329)

* re-enable stable CI (flutter#2402)

* [flutter_webview] Raise min Flutter SDK to stable (flutter#2425)

v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.

* [battery] cleanup for Android embedding post 1.12 (flutter#2400)

* [google_sign_in] Expose network error (flutter#2398)
sanekyy pushed a commit to sanekyy/plugins that referenced this pull request Dec 21, 2019
@sanekyy
[flutter_webview] Raise min Flutter SDK to stable (flutter#2425)
5ee6a24 
v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.
hjc22 pushed a commit to hjc22/plugins that referenced this pull request Jan 8, 2020
Merge remote-tracking branch 'flutterPlugin/master' into cash-video-c…
df1df41 
…acheing-01-08

* flutterPlugin/master: (30 commits)
  Update Gradle version (flutter#2448)
  [image_picker] support android V2 embedding (flutter#2430)
  [webview_flutter] Setup XCTests (flutter#2445)
  [video_player] Fixes video initialization future stall. (flutter#2134)
  [ci] Upgrade to Xcode 11.3 (flutter#2435)
  [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287)
  Migrate away from deprecated `BinaryMessages` (flutter#2444)
  [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335)
  [ios_platform_images] Removed android support from the pubspec. (flutter#2432)
  [google_sign_in] Expose network error (flutter#2398)
  [battery] cleanup for Android embedding post 1.12 (flutter#2400)
  [flutter_webview] Raise min Flutter SDK to stable (flutter#2425)
  re-enable stable CI (flutter#2402)
  [in_app_purchase]Change a comment. (flutter#2329)
  [google_sign_in] Pass the client id to the platform interface. (flutter#2427)
  [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414)
  [url_launcher_platform_interface] use non static token for platform interface (flutter#2418)
  [plugin_platform_interface] Don't use const Object as a token (flutter#2417)
  Update endorsed macos plugins readme and update others (flutter#2407)
  [webview_flutter] add gesture navigation for iOS (flutter#2339)
  ...

# Conflicts:
#	packages/video_player/video_player/CHANGELOG.md
#	packages/video_player/video_player/pubspec.yaml
HenriBeck pushed a commit to HenriBeck/plugins that referenced this pull request Jan 22, 2020
Revert "[flutter_webview] Raise min Flutter SDK to stable (flutter#2425…
723e091 
…)"

This reverts commit 2be4c80.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
[flutter_webview] Raise min Flutter SDK to stable (flutter#2425)
434d006 
v2 embedding apps no longer need to special case their Flutter SDK
requirement like they have since v0.3.15+3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amirh amirh amirh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mklim @ened @xster @amirh @googlebot