Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

In practice, the review response rate for these auto-assignments is generally quite low. The result is that we frequently have PRs with reviewers assigned but who never actually review; this makes following up on PR status in PR triage more difficult, and can create confusion for new contributors (who believe their PR has a review when, functionally, it doesn't).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

In practice, the review response rate for these auto-assignments is generally quite low. The result is that we frequently have PRs with reviewers assigned but who never actually review; this makes following up on PR status in PR triage more difficult, and can create confusion for new contributors (who believe their PR has a review when, functionally, it doesn't).
@stuartmorgan-g
Copy link
Contributor Author

@bparrishMines @ditman @cyanglaz @LHLL @gaaclarke This is a proposal, we don't necessarily need to do the full removal. However, I would like anyone in this file to commit to actively monitoring their auto-assigned review requests. That means that when auto-assigned you should always either:

  • actually review the PR, or
  • promptly update the PR to remove yourself as a reviewer if you aren't planning to review it

If there are packages for which you want to commit to that, please comment here to let me know what those are. (E.g., @cyanglaz maybe you'd want to narrow your assignments to iOS implementations of some package?)

Not commenting will be assumed to mean you aren't actively monitoring PRs here, in which case I'll remove you from the file 🙂

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not opposed to this removing the file, also not opposed to adding myself as:

**/*_web/**  @ditman

(not sure if those glob patterns would work, basically monitor anything that ends up in _web)

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would also be fine with committing to webview_flutter PRs since I've been working across the entire plugin for the last couple months.

@stuartmorgan-g stuartmorgan-g changed the title Remove CODEOWNERS Remove most CODEOWNERS Feb 4, 2022
@stuartmorgan-g
Copy link
Contributor Author

I've updated this to leave the file in place with just the commitments mentioned above. We'll see how that goes!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 4, 2022
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants