-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher_web] Update min Flutter version #4735
[url_launcher_web] Update min Flutter version #4735
Conversation
The change in 2.0.7 requires Flutter 2.10, but the min SDK version wasn't updated so it would break people who are still on 2.8 (or earlier). 2.0.7 has been retracted on pub.dev to address that; this will effectively re-release 2.0.7 with the right constraints.
|
Test are failing because our master pin is too old :/ Hopefully we can resolve that today. |
The new pin has landed a few minutes ago, I'm going to restart tests here. We need to do this with PointerInterceptor too, even though I couldn't find any reports in the bug tracker. |
|
The Flutter version on master is still too old. Apparently it hasn't been bumped yet. |
|
I'll start the flutter roller and try again once the latest main lands into the repo. |
Added `-0` to the version so pub picks up "dev"/"pre" master versions too. (Tested with PointerInterceptor)
Revert 995c03b now that master self reports as 2.11...
|
Agh, jeez, I need to do this change AND rebase the branch. I'm dumb. |
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mention it earlier, but thanks for cleaning up the CHANGELOG too, it's going to look much better in pub.dev!
The change in 2.0.7 requires Flutter 2.10, but the min SDK version
wasn't updated so it would break people who are still on 2.8 (or
earlier).
2.0.7 has been retracted on pub.dev to address that; this will
effectively re-release 2.0.7 with the right constraints.
(Also fixes heading formats in the changelog, since I noticed
that the display on pub.dev is currently very strange.)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).