Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

The change in 2.0.7 requires Flutter 2.10, but the min SDK version
wasn't updated so it would break people who are still on 2.8 (or
earlier).

2.0.7 has been retracted on pub.dev to address that; this will
effectively re-release 2.0.7 with the right constraints.

(Also fixes heading formats in the changelog, since I noticed
that the display on pub.dev is currently very strange.)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

The change in 2.0.7 requires Flutter 2.10, but the min SDK version
wasn't updated so it would break people who are still on 2.8 (or
earlier).

2.0.7 has been retracted on pub.dev to address that; this will
effectively re-release 2.0.7 with the right constraints.
@stuartmorgan-g
Copy link
Contributor Author

Test are failing because our master pin is too old :/ Hopefully we can resolve that today.

@ditman
Copy link
Member

ditman commented Feb 4, 2022

Test are failing because our master pin is too old :/ Hopefully we can resolve that today.

The new pin has landed a few minutes ago, I'm going to restart tests here.

We need to do this with PointerInterceptor too, even though I couldn't find any reports in the bug tracker.

@stuartmorgan-g
Copy link
Contributor Author

The Flutter version on master is still too old. Apparently it hasn't been bumped yet.

@ditman
Copy link
Member

ditman commented Feb 4, 2022

I'll start the flutter roller and try again once the latest main lands into the repo.

Added `-0` to the version so pub picks up "dev"/"pre" master versions too.

(Tested with PointerInterceptor)
Revert 995c03b now that master self reports as 2.11...
@ditman
Copy link
Member

ditman commented Feb 5, 2022

Agh, jeez, I need to do this change AND rebase the branch. I'm dumb.

@ditman ditman self-requested a review February 5, 2022 00:16
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mention it earlier, but thanks for cleaning up the CHANGELOG too, it's going to look much better in pub.dev!

@ditman ditman added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile labels Feb 5, 2022
@fluttergithubbot fluttergithubbot merged commit 63f4948 into flutter:main Feb 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2022
@stuartmorgan-g stuartmorgan-g deleted the url-launch-web-min-2-10 branch April 19, 2022 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p: url_launcher platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants