From f55d2f165952b30c9be53d7c8d5cdd7c8914333d Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Tue, 10 May 2022 09:36:46 +0200 Subject: [PATCH 1/4] * Removes ignoring `public_member_api_docs` lint. * Fixes `use_key_in_widget_constructors` lint. Fixes https://github.com/flutter/flutter/issues/103389 --- packages/local_auth/local_auth/CHANGELOG.md | 5 +++++ packages/local_auth/local_auth/example/lib/main.dart | 4 ++-- .../local_auth/example/lib/readme_excerpts.dart | 9 +++++---- packages/local_auth/local_auth/lib/src/local_auth.dart | 6 ------ packages/local_auth/local_auth/pubspec.yaml | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/local_auth/local_auth/CHANGELOG.md b/packages/local_auth/local_auth/CHANGELOG.md index 6765b497e506..ff109050326e 100644 --- a/packages/local_auth/local_auth/CHANGELOG.md +++ b/packages/local_auth/local_auth/CHANGELOG.md @@ -1,3 +1,8 @@ +## 2.0.2 + +* Removes ignoring `public_member_api_docs` lint. +* Fixes `use_key_in_widget_constructors` lint. + ## 2.0.1 * Restores the ability to import `error_codes.dart`. diff --git a/packages/local_auth/local_auth/example/lib/main.dart b/packages/local_auth/local_auth/example/lib/main.dart index cc687f562402..bd86914728c6 100644 --- a/packages/local_auth/local_auth/example/lib/main.dart +++ b/packages/local_auth/local_auth/example/lib/main.dart @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: public_member_api_docs - import 'dart:async'; import 'package:flutter/material.dart'; @@ -14,7 +12,9 @@ void main() { runApp(const MyApp()); } +/// MyApp is the Main Application. class MyApp extends StatefulWidget { + /// Default Constructor const MyApp({Key? key}) : super(key: key); @override diff --git a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart index 25ddfe0fa62f..4118539fc9d0 100644 --- a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart +++ b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart @@ -5,8 +5,6 @@ // This file exists solely to host compiled excerpts for README.md, and is not // intended for use as an actual example application. -// ignore_for_file: public_member_api_docs - import 'package:flutter/material.dart'; // #docregion ErrorHandling import 'package:flutter/services.dart'; @@ -24,10 +22,13 @@ import 'package:local_auth_ios/local_auth_ios.dart'; // #enddocregion CustomMessages void main() { - runApp(MyApp()); + runApp(const MyApp()); } - +/// MyApp is the Main Application. class MyApp extends StatefulWidget { + /// Default Constructor + const MyApp({Key? key}) : super(key: key); + @override State createState() => _MyAppState(); } diff --git a/packages/local_auth/local_auth/lib/src/local_auth.dart b/packages/local_auth/local_auth/lib/src/local_auth.dart index 206bd04f7b32..2dce66df6a9c 100644 --- a/packages/local_auth/local_auth/lib/src/local_auth.dart +++ b/packages/local_auth/local_auth/lib/src/local_auth.dart @@ -2,12 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// This is a temporary ignore to allow us to land a new set of linter rules in a -// series of manageable patches instead of one gigantic PR. It disables some of -// the new lints that are already failing on this plugin, for this plugin. It -// should be deleted and the failing lints addressed as soon as possible. -// ignore_for_file: public_member_api_docs - import 'dart:async'; import 'package:flutter/services.dart'; diff --git a/packages/local_auth/local_auth/pubspec.yaml b/packages/local_auth/local_auth/pubspec.yaml index 087b84920bb9..119b8d778cbc 100644 --- a/packages/local_auth/local_auth/pubspec.yaml +++ b/packages/local_auth/local_auth/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Android and iOS devices to allow local authentication via fingerprint, touch ID, face ID, passcode, pin, or pattern. repository: https://github.com/flutter/plugins/tree/main/packages/local_auth/local_auth issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+local_auth%22 -version: 2.0.1 +version: 2.0.2 environment: sdk: ">=2.14.0 <3.0.0" From 94284d36e48cc8b721159738fff3944c25a7a687 Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Tue, 10 May 2022 09:44:43 +0200 Subject: [PATCH 2/4] Format --- packages/local_auth/local_auth/example/lib/readme_excerpts.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart index 4118539fc9d0..bf13e5fa9073 100644 --- a/packages/local_auth/local_auth/example/lib/readme_excerpts.dart +++ b/packages/local_auth/local_auth/example/lib/readme_excerpts.dart @@ -24,6 +24,7 @@ import 'package:local_auth_ios/local_auth_ios.dart'; void main() { runApp(const MyApp()); } + /// MyApp is the Main Application. class MyApp extends StatefulWidget { /// Default Constructor From cfb34ce90a78f46b70aa6a967d0f23ab32f6ef91 Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Tue, 10 May 2022 09:51:52 +0200 Subject: [PATCH 3/4] `public_member_api_docs` is in the example. --- packages/local_auth/local_auth/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/local_auth/local_auth/CHANGELOG.md b/packages/local_auth/local_auth/CHANGELOG.md index ff109050326e..a1e9970c53c6 100644 --- a/packages/local_auth/local_auth/CHANGELOG.md +++ b/packages/local_auth/local_auth/CHANGELOG.md @@ -1,6 +1,6 @@ ## 2.0.2 -* Removes ignoring `public_member_api_docs` lint. +* Removes ignoring `public_member_api_docs` lint in the example. * Fixes `use_key_in_widget_constructors` lint. ## 2.0.1 From 8f147fee678cbd3f6ddb470fba70639c419ae74d Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Tue, 10 May 2022 09:53:26 +0200 Subject: [PATCH 4/4] Fix changelog. --- packages/local_auth/local_auth/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/local_auth/local_auth/CHANGELOG.md b/packages/local_auth/local_auth/CHANGELOG.md index a1e9970c53c6..ec27d1781af8 100644 --- a/packages/local_auth/local_auth/CHANGELOG.md +++ b/packages/local_auth/local_auth/CHANGELOG.md @@ -1,7 +1,7 @@ ## 2.0.2 -* Removes ignoring `public_member_api_docs` lint in the example. -* Fixes `use_key_in_widget_constructors` lint. +* Fixes `use_key_in_widget_constructors` lint in the example. +* Removes ignoring `public_member_api_docs` lint. ## 2.0.1