From 4966f499627048869cb7e57deb579949c8ed0e7e Mon Sep 17 00:00:00 2001 From: nkmrh Date: Wed, 25 Jul 2018 14:55:27 +0900 Subject: [PATCH 1/4] Prevent white line after resize --- packages/image_picker/ios/Classes/ImagePickerPlugin.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/image_picker/ios/Classes/ImagePickerPlugin.m b/packages/image_picker/ios/Classes/ImagePickerPlugin.m index 8ddf86c5d5a9..10185776be39 100644 --- a/packages/image_picker/ios/Classes/ImagePickerPlugin.m +++ b/packages/image_picker/ios/Classes/ImagePickerPlugin.m @@ -216,8 +216,8 @@ - (UIImage *)scaledImage:(UIImage *)image bool shouldDownscale = shouldDownscaleWidth || shouldDownscaleHeight; if (shouldDownscale) { - double downscaledWidth = (height / originalHeight) * originalWidth; - double downscaledHeight = (width / originalWidth) * originalHeight; + double downscaledWidth = floor((height / originalHeight) * originalWidth); + double downscaledHeight = floor((width / originalWidth) * originalHeight); if (width < height) { if (!hasMaxWidth) { From 1de5e0d98f5589d505ca5f08534efd19da0cb493 Mon Sep 17 00:00:00 2001 From: nkmrh Date: Wed, 25 Jul 2018 15:25:18 +0900 Subject: [PATCH 2/4] Update AUTHORS --- AUTHORS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 15e1a8c80e44..a816f43389de 100644 --- a/AUTHORS +++ b/AUTHORS @@ -14,4 +14,5 @@ Hayden Flinner Stefano Rodriguez Salvatore Giordano Brian Armstrong -Fabricio Nogueira \ No newline at end of file +Fabricio Nogueira +Hajime Nakamura From 18b9a91888e2ad661d9c84637bb16c5ec6ce1097 Mon Sep 17 00:00:00 2001 From: nkmrh Date: Mon, 27 Aug 2018 09:56:58 +0900 Subject: [PATCH 3/4] Bumping version and updating CHANGELOG --- packages/image_picker/CHANGELOG.md | 4 ++++ packages/image_picker/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/image_picker/CHANGELOG.md b/packages/image_picker/CHANGELOG.md index a730bbb67409..d0cfcf734595 100644 --- a/packages/image_picker/CHANGELOG.md +++ b/packages/image_picker/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.4.8 + +* Bugfix: on iOS prevent to appear one pixel white line on resized image. + ## 0.4.7 * Added missing video_player package dev dependency. diff --git a/packages/image_picker/pubspec.yaml b/packages/image_picker/pubspec.yaml index 44f46798fc6a..b311fca237e9 100755 --- a/packages/image_picker/pubspec.yaml +++ b/packages/image_picker/pubspec.yaml @@ -5,7 +5,7 @@ authors: - Flutter Team - Rhodes Davis Jr. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker -version: 0.4.7 +version: 0.4.8 flutter: plugin: From 74aaaa9063dc131f38d33ead5388363029489b81 Mon Sep 17 00:00:00 2001 From: nkmrh Date: Wed, 29 Aug 2018 10:35:38 +0900 Subject: [PATCH 4/4] Bumping version --- packages/image_picker/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/image_picker/pubspec.yaml b/packages/image_picker/pubspec.yaml index b311fca237e9..edfc6dc2c3b6 100755 --- a/packages/image_picker/pubspec.yaml +++ b/packages/image_picker/pubspec.yaml @@ -5,7 +5,7 @@ authors: - Flutter Team - Rhodes Davis Jr. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker -version: 0.4.8 +version: 0.4.9 flutter: plugin: