fix(battery_plus): Add iOS Privacy Info #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code compiles and runs as it did before. I followed the PR from the Flutter team as example and added it to the pod file: flutter/packages#5846 I am not sure if there is anything else I can do to verify this is all good. |
|
cc. @stuartmorgan |
vbuberen
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Looks good to me even though I don't like that such solution isn't communicated publicly, but via some correspondence as it is mentioned here: flutter/flutter#131940 (comment)
Let's mark it not as chore because I believe such changes should be included in release notes generated by Melos.
miquelbeltran
changed the title
Good catch! |
|
Merged, I will be preparing the rest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).