-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of time series with mixed timezone offsets #68
Conversation
Seems ok, but just a heads up that we may have to switch away from pytz in the future https://github.com/stub42/pytz/blob/master/src/README.rst#issues--limitations
|
Jup, good point. As we heavily rely on Pandas for the (element-wise) conversion of timezones, we follow the developments on their side. See pandas-dev/pandas#59089 as pytz will be an optional dependency in one of the following releases. Note also that we have some tests already relying on the native timezone implementation (e.g. https://github.com/fluves/pywaterinfo/blob/master/tests/test_waterinfo.py#L307) |
@binomaiheu is it possible that on the current requests to KIWIS all headers get a no-cache property, e.g. |
Hmm, we checked, but at first sight, the cache header config of the KiWIS API itself doesn't seem to have changed. Checking with the network admins if this could be due to firewall configuration changes... |
Note that the unit tests are currently failing as I have to request a new HIC token for running the unit tests. |
HIC account update was succesfull. @binomaiheu let me now if the caching on the reverse proxy would been adjusted. I'm merging this PR now |
See #67 for the discussion. This PR handles the request of a custom timezone over a period with mixed timezone offsets. Previously a warning was raised by Pandas and the timestamps were not parsed as pandas Timestamps.