From e84d89334082b27ee094178f85480a24294d4691 Mon Sep 17 00:00:00 2001 From: Balazs Nadasdi Date: Fri, 17 Nov 2023 13:35:09 +0100 Subject: [PATCH 1/3] docs: add docs about ipv6 Resolves #462 Signed-off-by: Balazs Nadasdi --- docs/use_tf_controller/with-ipv6.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 docs/use_tf_controller/with-ipv6.md diff --git a/docs/use_tf_controller/with-ipv6.md b/docs/use_tf_controller/with-ipv6.md new file mode 100644 index 00000000..ece81230 --- /dev/null +++ b/docs/use_tf_controller/with-ipv6.md @@ -0,0 +1,16 @@ +# Use TF-Controller with IPv6 addresses. + +TF-Controller uses pod IP address to communicate with the runner instance. This +logic fails when the runner pod has IPv6 address instead of IPv4 as it would try +to construct a hostname from the IP address. + +The TF-Controller has a flag to use pod subdomain resolution instead of an IP +address, with that enabled the controller will use cluster subdomains and it +works with IPv6 addresses as the resolution is happening on cluster level. + +To enable this feature, you can set `usePodSubdomainResolution` to `true` in the +Helm values file: + +```yaml +usePodSubdomainResolution: true +``` From e3caf97029b9cbcc01aa84c886b1ab81fb884bef Mon Sep 17 00:00:00 2001 From: Balazs Nadasdi Date: Wed, 22 Nov 2023 16:09:54 +0100 Subject: [PATCH 2/3] rewording Signed-off-by: Balazs Nadasdi --- docs/use_tf_controller/with-ipv6.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/use_tf_controller/with-ipv6.md b/docs/use_tf_controller/with-ipv6.md index ece81230..0fea50b7 100644 --- a/docs/use_tf_controller/with-ipv6.md +++ b/docs/use_tf_controller/with-ipv6.md @@ -1,11 +1,11 @@ # Use TF-Controller with IPv6 addresses. -TF-Controller uses pod IP address to communicate with the runner instance. This -logic fails when the runner pod has IPv6 address instead of IPv4 as it would try -to construct a hostname from the IP address. +TF-Controller uses pod IPv4 address to generate the in-cluster hostname to +communicate with the runner instance. This logic fails when the runner pod has +IPv6 address instead of IPv4. The TF-Controller has a flag to use pod subdomain resolution instead of an IP -address, with that enabled the controller will use cluster subdomains and it +address, with that enabled the controller will use cluster subdomains, and it works with IPv6 addresses as the resolution is happening on cluster level. To enable this feature, you can set `usePodSubdomainResolution` to `true` in the From fea3248a4efa55ca2f2de00f9a20319865fd46b7 Mon Sep 17 00:00:00 2001 From: Balazs Nadasdi Date: Thu, 23 Nov 2023 16:32:16 +0100 Subject: [PATCH 3/3] Update docs/use_tf_controller/with-ipv6.md Co-authored-by: Yiannis Triantafyllopoulos <8741709+yiannistri@users.noreply.github.com> --- docs/use_tf_controller/with-ipv6.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/use_tf_controller/with-ipv6.md b/docs/use_tf_controller/with-ipv6.md index 0fea50b7..4be091ae 100644 --- a/docs/use_tf_controller/with-ipv6.md +++ b/docs/use_tf_controller/with-ipv6.md @@ -6,7 +6,7 @@ IPv6 address instead of IPv4. The TF-Controller has a flag to use pod subdomain resolution instead of an IP address, with that enabled the controller will use cluster subdomains, and it -works with IPv6 addresses as the resolution is happening on cluster level. +works with IPv6 addresses as the resolution is happening at cluster level. To enable this feature, you can set `usePodSubdomainResolution` to `true` in the Helm values file: