Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end tests and various fixes to flux2-sync chart #23

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Nov 26, 2021

What this PR does / why we need it:

This PR adds basic e2e tests for the flux2-sync chart. It also comes with various fixes and breaking changes to flux2-sync.

Which issue this PR fixes

Fix: #22

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the enhancement New feature or request label Nov 26, 2021
@stefanprodan stefanprodan changed the title Add end-to-end test and various fixes to flux2-sync chart Add end-to-end tests and various fixes to flux2-sync chart Nov 26, 2021
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@haarchri
Copy link
Collaborator

thanks for E2E tests and fixing the chart

@haarchri haarchri merged commit 8fc01a3 into main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flux-sync - ref: got "string", expected "map"
2 participants