Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstall to e2e test suite #25

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Add uninstall to e2e test suite #25

merged 1 commit into from
Dec 6, 2021

Conversation

stefanprodan
Copy link
Member

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested

@stefanprodan
Copy link
Member Author

No idea why the lint job no longer creates a kind cluster....

@dwerder
Copy link
Collaborator

dwerder commented Nov 29, 2021

The problem is, that we check if there were changes in the chart and only then we start a kind cluster and the tests. The condition check is missing on the chart linting test. Thats why it is triggered, even so kind is not started.

Fix is to add the following line
https://github.com/fluxcd-community/helm-charts/blob/main/.github/workflows/lint-test.yaml#L41
if: steps.list-changed.outputs.changed == 'true'

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Copy link
Member Author

@dwerder I really doubt Helm knows to properly uninstall Flux, it works because Helm doesn't check for CRD deletion, but CRDs are stuck on the cluster forever blocking namespaces and everything else. The only way to uninstall Flux without breaking your whole cluster is by suspending first all Flux custom resources, then by patching them to remove finalizers.

@stefanprodan
Copy link
Member Author

I guess we could fix this by having an uninstall hook that calls flux uninstall --keep-namespace.

@haarchri haarchri merged commit 3279d47 into main Dec 6, 2021
@haarchri haarchri deleted the uninstall-e2e branch December 6, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants