From ca6867a6b1a9526341d8cfe74aeb3bc32011f69b Mon Sep 17 00:00:00 2001 From: "ta924@yahoo.com" Date: Thu, 3 Aug 2023 11:16:25 -0500 Subject: [PATCH] fix trafficIncrease calls when using confirmPromotion Signed-off-by: ta924@yahoo.com --- pkg/controller/scheduler.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/controller/scheduler.go b/pkg/controller/scheduler.go index 222d63686..9dd8c0e06 100644 --- a/pkg/controller/scheduler.go +++ b/pkg/controller/scheduler.go @@ -456,7 +456,10 @@ func (c *Controller) advanceCanary(name string, namespace string) { // strategy: Canary progressive traffic increase if c.nextStepWeight(cd, canaryWeight) > 0 { // run hook only if traffic is not mirrored - if !mirrored { + if !mirrored && + (cd.Status.Phase != flaggerv1.CanaryPhasePromoting && + cd.Status.Phase != flaggerv1.CanaryPhaseWaitingPromotion && + cd.Status.Phase != flaggerv1.CanaryPhaseFinalising) { if promote := c.runConfirmTrafficIncreaseHooks(cd); !promote { return }