From e97334d7c1bb788502bff6ad74603b4b5c1027ca Mon Sep 17 00:00:00 2001 From: Misteur-Z <22374424+Misteur-Z@users.noreply.github.com> Date: Fri, 29 Oct 2021 14:37:21 +0200 Subject: [PATCH 1/2] Warning Signed-off-by: Misteur-Z <22374424+Misteur-Z@users.noreply.github.com> --- docs/gitbook/faq.md | 39 ++++++++++++++++++++++++++++++ docs/gitbook/usage/how-it-works.md | 2 +- 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/docs/gitbook/faq.md b/docs/gitbook/faq.md index b7a583be8..1b54f18d3 100644 --- a/docs/gitbook/faq.md +++ b/docs/gitbook/faq.md @@ -858,3 +858,42 @@ spec: mtls: mode: DISABLE ``` + +## ExternalDNS + +### Can I use annotations? + +Flagger propagates annotations (and labels) to all the generated apex, +primary and canary objects. This allows using external-dns annotations. + +You can configure Flagger to set annotations with: + +```yaml +spec: + service: + apex: + annotations: + external-dns.alpha.kubernetes.io/hostname: "mydomain.com" + primary: + annotations: + external-dns.alpha.kubernetes.io/hostname: "primary.mydomain.com" + canary: + annotations: + external-dns.alpha.kubernetes.io/hostname: "canary.mydomain.com" +``` + +### Multiple sources and Istio + +:warning: The apex annotations are added to both the generated Kubernetes Services and the generated Istio +VirtualServices objects. If you have configured external-dns to use both sources, +this will create conflicts! + +```yaml + spec: + containers: + args: + - --source=service # choose only one + - --source=istio-virtualservice # of these two +``` + +[Checkout ExeternalDNS documentation](https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/istio.md) diff --git a/docs/gitbook/usage/how-it-works.md b/docs/gitbook/usage/how-it-works.md index af02fe2aa..d2a77c525 100644 --- a/docs/gitbook/usage/how-it-works.md +++ b/docs/gitbook/usage/how-it-works.md @@ -186,7 +186,7 @@ spec: Note that the `apex` annotations are added to both the generated Kubernetes Service and the generated service mesh/ingress object. This allows using external-dns with Istio `VirtualServices` -and `TraefikServices`. +and `TraefikServices`. Beware of configuration conflicts [here](../faq.md#ExternalDNS). Besides port mapping and metadata, the service specification can contain URI match and rewrite rules, timeout and retry polices: From 944cc8ef622adb7b3727be8818e3a6da6cf3aa50 Mon Sep 17 00:00:00 2001 From: Misteur-Z <22374424+Misteur-Z@users.noreply.github.com> Date: Fri, 29 Oct 2021 15:43:06 +0200 Subject: [PATCH 2/2] Remove emoji Signed-off-by: Misteur-Z <22374424+Misteur-Z@users.noreply.github.com> --- docs/gitbook/faq.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gitbook/faq.md b/docs/gitbook/faq.md index 1b54f18d3..f4b8a8f7a 100644 --- a/docs/gitbook/faq.md +++ b/docs/gitbook/faq.md @@ -884,7 +884,7 @@ spec: ### Multiple sources and Istio -:warning: The apex annotations are added to both the generated Kubernetes Services and the generated Istio +**/!\\** The apex annotations are added to both the generated Kubernetes Services and the generated Istio VirtualServices objects. If you have configured external-dns to use both sources, this will create conflicts!