Add kuma support for progressive traffic shifting canaries #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Signed-off-by: John Harris <john.harris@konghq.com>
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 57.23% 57.36% +0.12%
==========================================
Files 76 78 +2
Lines 6162 6297 +135
==========================================
+ Hits 3527 3612 +85
- Misses 2105 2148 +43
- Partials 530 537 +7
Continue to review full report at Codecov.
|
stefanprodan
reviewed
Jan 5, 2022
| "github.com/fluxcd/flagger/pkg/metrics/providers" | ||
| ) | ||
|
|
||
| // TODO [@johnharris85]: Do we also need to select by mesh here? These could be duplicated (but in different meshes). |
There was a problem hiding this comment.
I don't think duplication is possible since the metric refers to a service by name and namespace which are unique per cluster. Can you add the same service to two Kuma meshes?
stefanprodan
reviewed
Jan 5, 2022
Signed-off-by: John Harris <john.harris@konghq.com>
stefanprodan
reviewed
Jan 5, 2022
Signed-off-by: John Harris <john.harris@konghq.com>
stefanprodan
changed the title
stefanprodan
approved these changes
Jan 6, 2022
|
Awesome, thanks for the review! I almost have blue-green finished too so if we can get this merged I'll throw that up later this week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Kuma service mesh to Flagger.
Currently only canaries are supported, but I'm planning to add A/B testing in another PR when I get around to it.