From 4dd6102a0f6c1054fbf29504c7ccffd70ca355ae Mon Sep 17 00:00:00 2001 From: Mae Anne Large Date: Tue, 21 Jun 2022 09:10:01 -0500 Subject: [PATCH 1/2] include Contour retryOn in the sample canary without this change the HTTPProxy - podinfo.test was not getting created due to the following warning: ``` test 4m11s Warning Synced canary/podinfo HTTPProxy podinfo.test create error: HTTPProxy.projectcontour.io "podinfo" is invalid: spec.routes.retryPolicy.retryOn: Unsupported value: "": supported values: "5xx", "gateway-error", "reset", "connect-failure", "retriable-4xx", "refused-stream", "retriable-status-codes", "retriable-headers", "cancelled", "deadline-exceeded", "internal", "resource-exhausted", "unavailable" ``` Signed-off-by: Mae Anne Large Signed-off-by: Mae Large --- docs/gitbook/tutorials/contour-progressive-delivery.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/gitbook/tutorials/contour-progressive-delivery.md b/docs/gitbook/tutorials/contour-progressive-delivery.md index cfff41f92..344dcf9b5 100644 --- a/docs/gitbook/tutorials/contour-progressive-delivery.md +++ b/docs/gitbook/tutorials/contour-progressive-delivery.md @@ -90,6 +90,8 @@ spec: retries: attempts: 3 perTryTimeout: 5s + # supported values for retryOn - https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#x-envoy-retry-on + retryOn: "5xx" # define the canary analysis timing and KPIs analysis: # schedule interval (default 60s) From 1bb4afaeacd06060db427e66f38d4f83ea4329d5 Mon Sep 17 00:00:00 2001 From: Mae Large Date: Wed, 22 Jun 2022 06:06:14 -0500 Subject: [PATCH 2/2] updated retryOn supported values link to point to contour's api doc Signed-off-by: Mae Large --- docs/gitbook/tutorials/contour-progressive-delivery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gitbook/tutorials/contour-progressive-delivery.md b/docs/gitbook/tutorials/contour-progressive-delivery.md index 344dcf9b5..29abec2d2 100644 --- a/docs/gitbook/tutorials/contour-progressive-delivery.md +++ b/docs/gitbook/tutorials/contour-progressive-delivery.md @@ -90,7 +90,7 @@ spec: retries: attempts: 3 perTryTimeout: 5s - # supported values for retryOn - https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#x-envoy-retry-on + # supported values for retryOn - https://projectcontour.io/docs/main/config/api/#projectcontour.io/v1.RetryOn retryOn: "5xx" # define the canary analysis timing and KPIs analysis: