Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stackdriver metrics analysis #991

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

somtochiama
Copy link
Member

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@somtochiama somtochiama marked this pull request as draft August 27, 2021 14:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #991 (b0b68bd) into main (8b42ce3) will decrease coverage by 0.11%.
The diff coverage is 44.82%.

❗ Current head b0b68bd differs from pull request most recent head 056ba67. Consider uploading reports for the commit 056ba67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   56.97%   56.85%   -0.12%     
==========================================
  Files          73       74       +1     
  Lines        5924     5982      +58     
==========================================
+ Hits         3375     3401      +26     
- Misses       2048     2073      +25     
- Partials      501      508       +7     
Impacted Files Coverage Δ
pkg/metrics/providers/factory.go 0.00% <0.00%> (ø)
pkg/metrics/providers/stackdriver.go 46.42% <46.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b42ce3...056ba67. Read the comment docs.

@somtochiama somtochiama marked this pull request as ready for review August 30, 2021 11:33
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌷

PS. Please squash your commits.

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 88b1327 into fluxcd:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants