Fix makefile envtest setup and usage #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor logic to install helper tools into one function in the Makefile. Add support for envtest to help install tools like kubectl, etcd which helps users run tests more conveniently. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
aryan9600/setup-testenv
branch
from
fe5b482 to
81a0870
Compare
relu
added a commit
that referenced
this pull request
Jan 14, 2022
The check() run started to fail after #2288 since ENVTEST_ARCH was not set correctly on ARM/ARM64. This should fix the problem for the flux-go and flux-scm AUR packages. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
added a commit
that referenced
this pull request
Jan 14, 2022
The check() run started to fail after #2288 since ENVTEST_ARCH was not set correctly on ARM/ARM64. This should fix the problem for the flux-go and flux-scm AUR packages. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
souleb
pushed a commit
to souleb/flux2
that referenced
this pull request
Jul 10, 2023
The check() run started to fail after fluxcd#2288 since ENVTEST_ARCH was not set correctly on ARM/ARM64. This should fix the problem for the flux-go and flux-scm AUR packages. Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor logic to install helper tools into one function in the
Makefile. Add support for envtest to help install tools like kubectl,
etcd which helps users run tests more conveniently.
Ref: #2273
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com