Add chartutil package and ValuesReference type to APIs
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
requested review from
darkowlzz,
hiddeco and
a team
as code owners
matheuscscp
approved these changes
Dec 9, 2024
darkowlzz
reviewed
Dec 12, 2024
|
|
||
| // ValuesReference contains a reference to a resource containing Helm values, | ||
| // and optionally the key they can be found at. | ||
| type ValuesReference struct { |
There was a problem hiding this comment.
In the context of this package, the type seems to be generically named. LocalObjectReference, NamespacedObjectReference, SecretKeyReference, KubeConfigReference, etc have the context in the name prefix. Something like HelmValuesReference would have been better.
I'm assuming that because it originated in helm-controller API, it was named this way. But in this package, the name seems confusing compared to others in the package.
Since helm-controller now has an alias to this, if we want to, we can rename this to anything without breaking the helm-controller API.
It feels like it's too late for the change now. I wouldn't insist on the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the logic used by helm-controller to query and merge Helm values to a shared package called
chartutil. In addition, the HelmRelease v2ValuesReferencewas copied topkg/apis. This will allow the reuse of values composition in Flux CLI.Part of: fluxcd/flux2#5101