Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fm): don't update T-P position if we aren't inserting a direct to #8974

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Sep 22, 2024

Fixes #8968

Summary of Changes

  • Don't update T-P position if we aren't inserting a direct to
  • Make T-P position update properly edit the definition so that it works with sync

Testing instructions

  • Make sure T-P updates when inserting a direct to
    • Wait a minute until confirming a direct to to a far away waypoint - make sure the T-P point moves to the airplane position when inserting
  • Make sure T-P does not move it is the FROM leg and making another modification that creates a temporary plan, for example, adding a hold somewhere

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@tracernz
Copy link
Member

Discord Username : tracernz
Object of testing : #8974
Aircraft : A32NX
Tier of Testing : 1
Date : 23/09/2024

Testing Process:
First tested the 2nd case per the original repro: ✅
Then tested the first case: T-P is updated once when the new DIR TO first creates a TMPY (this one should not be shown on the ND!), and doesn't update again so the dashed path doesn't move with the plane as it should. It also did not update when inserted.❌

Testing Results:
Failed

Media:
image
image

@aguther aguther added A380X Related to the A380X aircraft A32NX Related to the A32NX aircraft labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Failed QA Ready to Test QA Tier 1
Projects
Status: 🟣 QA Team Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

fms: t-p shifts when flightplan revised
4 participants