Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8.1 compatibility #62

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Php 8.1 compatibility #62

merged 2 commits into from
Jan 10, 2023

Conversation

zamu87
Copy link
Contributor

@zamu87 zamu87 commented Jul 20, 2022

Added php 8.1 in composer.json and fixed trim(): Passing null to parameter #1 ($string) of type string is deprecated

@ihor-sviziev
Copy link
Contributor

Hi @fnogatz,
Could you please review this pull request?

@DominikFluegelEcoplan
Copy link

Hi @fnogatz ,

is there a possibility to review the pull request? Would be a pleasure!

Greetings

@stephansteiner
Copy link

Magento 2.4.5(-p1) has been released, we need to migrate all shops to 2.4.5 as soon as possible because of end of life of php 7.4.
Please review the pull request. Thank you

@sebastian-ehrling
Copy link

Hi @fnogatz
it is possible to merge this pull request?

thx a lot!

@SerhiiMandrykin
Copy link

Hi @fnogatz
Do you think you can merge it?

Thanks

@fnogatz fnogatz self-assigned this Jan 10, 2023
@fnogatz fnogatz merged commit ec36a91 into fnogatz:main Jan 10, 2023
@fnogatz
Copy link
Owner

fnogatz commented Jan 10, 2023

Thank you for the valuable contribution, @zamu87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants