[EDGEPATRON-131]-Added POST edge api for LOC patron #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinghAdes
requested review from
SreejaMangarapu,
gurleenkaurbp and
Vignesh-kalyanasundaram
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.TimeZone; | ||
| import java.util.*; |
| import org.folio.edge.patron.model.Account; | ||
| import org.folio.edge.patron.model.Charge; | ||
| import org.folio.edge.patron.model.Hold; | ||
| import org.folio.edge.patron.model.*; |
| @@ -151,6 +153,21 @@ public void handlePlaceItemHold(RoutingContext ctx) { | |||
| t -> handleProxyException(ctx, t))); | |||
| } | |||
|
|
|||
| public void handlePatronRequest(RoutingContext ctx) { | |||
| if (ctx.body().asJsonObject() == null) { | |||
| badRequest(ctx, MSG_HOLD_NOBODY); | |||
There was a problem hiding this comment.
Please change the error message specific to this api
| logger.debug("response: " + respBody); | ||
| } | ||
|
|
||
| String contentType = resp.getHeader(HttpHeaders.CONTENT_TYPE.toString()); | ||
|
|
||
| if (resp.statusCode() < 400){ | ||
| if (resp.statusCode() < 400 && Objects.nonNull(respBody)){ |
There was a problem hiding this comment.
what is the use of new condition here?
There was a problem hiding this comment.
@Vignesh-kalyanasundaram :- just as precaution , There might be a case when we receive an empty or null response from mod-patron. in this case this code will not fail as NullPointer exception .
|
Vignesh-kalyanasundaram
approved these changes
Jun 10, 2024
gurleenkaurbp
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/EDGPATRON-131
Approcah:- Added edge api call for POST endpoint (/patron/account)