UITEN-290 - Make dependency on mod-reading-rooms optional. #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UITEN-290 - Make dependency on mod-reading-rooms optional.
Approach
Earlier "reading-room" interface was included in okapiInterfaces and have been marked as BREAKING and the version in package.json was bumped up. This PR intends to correct the same by moving the interface into optionalOkapiInterfaces list and reverting the version in package.json. Also, changelog has been updated to remove "BREAKING" signature for earlier change.
Note: I don't see any other team worked on this module after it was marked as breaking change. Hence I think it is safe to revert and I don't think any other team needs to be informed of this change.
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.