From 891f6e6fc576ee3ddb414f7d5f7f62cfc6b62a75 Mon Sep 17 00:00:00 2001 From: Marco 'Lubber' Wienkoop Date: Fri, 4 Sep 2020 00:22:56 +0200 Subject: [PATCH] fix(dropdown): very short menu had wrong order specificity The very short size variation did not work. It was always overridden by the short variation because both share same specificity, thus the declaration order matters. --- src/definitions/modules/dropdown.less | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/definitions/modules/dropdown.less b/src/definitions/modules/dropdown.less index 33c70d3573..8471e56901 100755 --- a/src/definitions/modules/dropdown.less +++ b/src/definitions/modules/dropdown.less @@ -448,12 +448,12 @@ select.ui.dropdown { @media only screen and (max-width : @largestMobileScreen) { & when (@variationDropdownShort) { - .ui.selection.dropdown[class*="very short"] .menu { - max-height: @selectionMobileMaxMenuHeight * 0.5; - } .ui.selection.dropdown.short .menu { max-height: @selectionMobileMaxMenuHeight * 0.75; } + .ui.selection.dropdown[class*="very short"] .menu { + max-height: @selectionMobileMaxMenuHeight * 0.5; + } } .ui.selection.dropdown .menu { max-height: @selectionMobileMaxMenuHeight; @@ -469,12 +469,12 @@ select.ui.dropdown { } @media only screen and (min-width: @tabletBreakpoint) { & when (@variationDropdownShort) { - .ui.selection.dropdown[class*="very short"] .menu { - max-height: @selectionTabletMaxMenuHeight * 0.5; - } .ui.selection.dropdown.short .menu { max-height: @selectionTabletMaxMenuHeight * 0.75; } + .ui.selection.dropdown[class*="very short"] .menu { + max-height: @selectionTabletMaxMenuHeight * 0.5; + } } .ui.selection.dropdown .menu { max-height: @selectionTabletMaxMenuHeight; @@ -490,12 +490,12 @@ select.ui.dropdown { } @media only screen and (min-width: @computerBreakpoint) { & when (@variationDropdownShort) { - .ui.selection.dropdown[class*="very short"] .menu { - max-height: @selectionComputerMaxMenuHeight * 0.5; - } .ui.selection.dropdown.short .menu { max-height: @selectionComputerMaxMenuHeight * 0.75; } + .ui.selection.dropdown[class*="very short"] .menu { + max-height: @selectionComputerMaxMenuHeight * 0.5; + } } .ui.selection.dropdown .menu { max-height: @selectionComputerMaxMenuHeight; @@ -511,12 +511,12 @@ select.ui.dropdown { } @media only screen and (min-width: @widescreenMonitorBreakpoint) { & when (@variationDropdownShort) { - .ui.selection.dropdown[class*="very short"] .menu { - max-height: @selectionWidescreenMaxMenuHeight * 0.5; - } .ui.selection.dropdown.short .menu { max-height: @selectionWidescreenMaxMenuHeight * 0.75; } + .ui.selection.dropdown[class*="very short"] .menu { + max-height: @selectionWidescreenMaxMenuHeight * 0.5; + } } .ui.selection.dropdown .menu { max-height: @selectionWidescreenMaxMenuHeight;