Fix: PHP Stan errors

.gitignore

@@ -3,4 +3,7 @@
 .DS_Store
 
 vendor
-composer.lock
+composer.lock
+
+src/Generated
+src/Orm

Makefile

@@ -19,4 +19,4 @@ codeception:
 	./vendor/bin/codecept run --env standalone
 
 .PHONY: ci
-ci: phpcs codeception
+ci: phpcs codeception phpstan

phpstan.neon

@@ -5,3 +5,4 @@ parameters:
         - src/Orm/Zed
     ignoreErrors:
         - '#.* on an unknown class Generated\\(Client|Glue|Service|Yves|Zed)\\.*#'
+        - '#.*\\ContentfulPageSearch\\.*#'

src/FondOfSpryker/Shared/Contentful/Renderer/AbstractRenderer.php

@@ -32,6 +32,10 @@ public function render(ContentfulEntryResponseTransfer $response, array $additio
         $placeholders = $this->getPlaceholders($response, $additionalPlaceholders);
         $placeholders = $this->mergeAdditionalPlaceholders($response, $placeholders, $additionalPlaceholders);
 
+        if (!method_exists($this, 'getTwigEnvironment')) {
+            return '';
+        }
+
         try {
             return $this->getTwigEnvironment()->render($this->getTemplatePath($response), $placeholders);
         } catch (Throwable $throwable) {

src/FondOfSpryker/Yves/Contentful/ContentfulDependencyProvider.php

@@ -5,7 +5,6 @@
 use Aptoma\Twig\Extension\MarkdownEngine\MichelfMarkdownEngine;
 use Aptoma\Twig\Extension\MarkdownExtension;
 use FondOfSpryker\Yves\Contentful\Dependency\Client\ContentfulToContentfulPageSearchClientBridge;
-use FondOfSpryker\Yves\Contentful\Dependency\Client\ContentfulToSearchClientBridge;
 use FondOfSpryker\Yves\Contentful\Dependency\Renderer\ContentfulToRendererBridge;
 use Spryker\Shared\Kernel\ContainerInterface;
 use Spryker\Yves\Kernel\AbstractBundleDependencyProvider;
@@ -28,11 +27,6 @@ class ContentfulDependencyProvider extends AbstractBundleDependencyProvider
      */
     public const CLIENT_STORE = 'CLIENT_STORE';
 
-    /**
-     * @var string
-     */
-    public const SEARCH_CLIENT = 'SEARCH_CLIENT';
-
     /**
      * @var string
      */
@@ -162,22 +156,6 @@ protected function provideCategoryStorageClient(Container $container): Container
         return $container;
     }
 
-    /**
-     * @param \Spryker\Yves\Kernel\Container $container
-     *
-     * @return \Spryker\Yves\Kernel\Container
-     */
-    protected function getSearchClient(Container $container): Container
-    {
-        $container[static::SEARCH_CLIENT] = function (Container $container) {
-            return new ContentfulToSearchClientBridge(
-                $container->getLocator()->search()->client(),
-            );
-        };
-
-        return $container;
-    }
-
     /**
      * @param \Spryker\Yves\Kernel\Container $container
      *

src/FondOfSpryker/Yves/Contentful/ContentfulFactory.php

@@ -32,7 +32,6 @@
 use FondOfSpryker\Yves\Contentful\Renderer\Navigation\Node\NavigationNodeFactoryInterface;
 use FondOfSpryker\Yves\Contentful\Renderer\Navigation\Node\NavigationNodeMapperInterface;
 use Spryker\Client\CategoryStorage\CategoryStorageClientInterface;
-use Spryker\Client\Search\SearchClientInterface;
 use Spryker\Client\Store\StoreClientInterface;
 use Spryker\Yves\Kernel\AbstractFactory;
 use Symfony\Component\HttpFoundation\RequestStack;
@@ -262,12 +261,4 @@ public function getLocale(): string
     {
         return $this->getProvidedDependency(ContentfulDependencyProvider::SERVICE_LOCALE);
     }
-
-    /**
-     * @return \Spryker\Client\Search\SearchClientInterface
-     */
-    public function getSearchClient(): SearchClientInterface
-    {
-        return $this->getProvidedDependency(ContentfulDependencyProvider::SEARCH_CLIENT);
-    }
 }

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/Category/NavigationItemCategoryMapper.php

@@ -15,12 +15,12 @@ class NavigationItemCategoryMapper implements NavigationItemMapperInterface
     /**
      * @var string
      */
-    private const KEY_CATEGORY_ID = 'typeId';
+    protected const KEY_CATEGORY_ID = 'typeId';
 
     /**
      * @var string
      */
-    private const KEY_CUSTOM_TEXT = 'customText';
+    protected const KEY_CUSTOM_TEXT = 'customText';
 
     /**
      * @return string
@@ -31,7 +31,7 @@ public function getType(): string
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemInterface
      */
@@ -48,7 +48,7 @@ public function createNavigationItem(array $navigation): NavigationItemInterface
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/ContentfulPage/NavigationItemContentfulPageMapper.php

@@ -15,12 +15,12 @@ class NavigationItemContentfulPageMapper implements NavigationItemMapperInterfac
     /**
      * @var string
      */
-    private const KEY_CONTENTFUL_ENTRY_ID = 'typeId';
+    protected const KEY_CONTENTFUL_ENTRY_ID = 'typeId';
 
     /**
      * @var string
      */
-    private const KEY_CUSTOM_TEXT = 'customText';
+    protected const KEY_CUSTOM_TEXT = 'customText';
 
     /**
      * @return string
@@ -31,7 +31,7 @@ public function getType(): string
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemInterface
      */
@@ -49,7 +49,7 @@ public function createNavigationItem(array $navigation): NavigationItemInterface
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/Custom/NavigationItemCustomMapper.php

@@ -15,12 +15,12 @@ class NavigationItemCustomMapper implements NavigationItemMapperInterface
     /**
      * @var string
      */
-    private const KEY_URL = 'url';
+    protected const KEY_URL = 'url';
 
     /**
      * @var string
      */
-    private const KEY_CUSTOM_TEXT = 'customText';
+    protected const KEY_CUSTOM_TEXT = 'customText';
 
     /**
      * @return string
@@ -31,7 +31,7 @@ public function getType(): string
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemInterface
      */
@@ -44,7 +44,7 @@ public function createNavigationItem(array $navigation): NavigationItemInterface
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/NavigationItemFactory.php

@@ -35,14 +35,14 @@ public function __construct(NavigationItemCollectionInterface $collection, array
     }
 
     /**
-     * @param array<<array<string>> $navigation
+     * @param array<mixed> $navigationItemsArray
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemCollectionInterface
      */
-    public function build(array $navigation): NavigationItemCollectionInterface
+    public function build(array $navigationItemsArray): NavigationItemCollectionInterface
     {
         $this->collection->clear();
-        foreach ($navigation as $navigationChild) {
+        foreach ($navigationItemsArray as $navigationChild) {
             // create navigation items recursively
             $item = $this->createNavigationItemRecursive($navigationChild);
             if ($item === null) {
@@ -56,7 +56,7 @@ public function build(array $navigation): NavigationItemCollectionInterface
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemInterface|null
      */
@@ -100,7 +100,7 @@ private function createNavigationItemRecursive(array $navigation): ?NavigationIt
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */
@@ -110,7 +110,7 @@ protected function hasType(array $navigation): bool
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return string
      */
@@ -120,7 +120,7 @@ protected function getType(array $navigation): string
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */
@@ -132,9 +132,9 @@ protected function hasChildren(array $navigation): bool
     }
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
-     * @return array<string>
+     * @return array<mixed>
      */
     protected function getChildren(array $navigation): array
     {

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/NavigationItemFactoryInterface.php

@@ -5,7 +5,7 @@
 interface NavigationItemFactoryInterface
 {
     /**
-     * @param array<string> $navigationItemsArray
+     * @param array<array<string>> $navigationItemsArray
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemCollectionInterface
      */

src/FondOfSpryker/Yves/Contentful/Renderer/Navigation/Item/NavigationItemMapperInterface.php

@@ -10,14 +10,14 @@ interface NavigationItemMapperInterface
     public function getType(): string;
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return \FondOfSpryker\Yves\Contentful\Renderer\Navigation\Item\NavigationItemInterface
      */
     public function createNavigationItem(array $navigation): NavigationItemInterface;
 
     /**
-     * @param array<string> $navigation
+     * @param array<mixed> $navigation
      *
      * @return bool
      */