-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete improvements #2843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="autocomplete-7-march-2024")
julia> using Pluto |
JunoLab/FuzzyCompletions.jl#15 would be nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to enable autocomplete on type (without having to press
<TAB>
), but it needs to be in a better shape before we do that :)This PR makes some improvements and adds a setting to preview always on autocomplete
In this PR
PLUTO_TOGGLE_CM_AUTOCOMPLETE_ON_TYPE(true)
to enable always on autocompletecomplete_anyword
forIdentifier
s onlysqrt(
, show a list of methods but ignore selecting onevalidFor
settingUsing
validFor
Codemirror gives the option
validFor
, which lets you say "i found the completions for the currently typed text, and if you type one of these characters, you can just filter the results instead of asking me again". I implemented this, and now it's more snappy!Before
Schermopname.2024-03-12.om.14.33.31.mov
After
Schermopname.2024-03-12.om.14.33.51.mov