Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(font): add commit-mono #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexanderl19
Copy link

@alexanderl19 alexanderl19 commented Jul 15, 2024

Adds Commit Mono v1.143 / v143.

Notes

Font files downloaded with default "customizations" from https://commitmono.com/ > 07 Customize then converted from otf to woff and woff2.

metadata.json

license url is set to the GitHub tag link (https://github.com/eigilnikolajsen/commit-mono/blob/v1.143/src/txt/license.txt), not commit (https://github.com/eigilnikolajsen/commit-mono/blob/a042aaa2a43da91544b1d02ee12819cb698db7d2/src/txt/license.txt). Should this be changed?

I've also selected to use the GitHub tag version of the font (v1.143) rather than the site version (v143). Not sure which one is preferable here.

Settings

  • Choose download letter spacing: 0%
  • Choose download line height: 1
  • Choose download features
    • ss01: Ligatures <= != ===: OFF
    • ss02: Arrows >-> =>: OFF
    • ss03: Smart case (1:1) 2+3: ON
    • ss04: Symbol spacing ... <<: ON
    • ss05: Smart kerning (immi): ON
  • Choose download alternate characters: All Default

"Customization" JSON:

{"weight":400,"italic":false,"alternates":{"cv01":false,"cv02":false,"cv03":false,"cv04":false,"cv05":false,"cv06":false,"cv07":false,"cv08":false,"cv09":false,"cv10":false,"cv11":false},"features":{"ss01":false,"ss02":false,"ss03":true,"ss04":true,"ss05":true},"letterSpacing":0,"lineHeight":1}

Conversion

Downloaded fonts are otf files. The following tools were used for conversion.

otf to woff: sfnt2woff-zopfli downloaded via bramstein/webfonttools tap (v1.1.0)

otf to woff2: woff2 via brew (v1.0.2)

Both using default settings.

Variable Font

Commit Mono is a variable font. I couldn't find any guidance on providing variable font files for non Google Font fonts. I'd like to be able to contribute those as well since they support OpenType features.

Edit: Just saw fontsource/fontsource#728.

Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. I was on holiday. 🎉

Everything looks good to me, except for the weights that are split at intervals of 25. This can be problematic if this font is ever uploaded to Google Fonts, as they will produce static variants with weight intervals of 100. In the long run, that could lead to a breaking change in a patch release due to how our system is set up (which automatically transitions to Google Fonts when available).

Could you remove the extra weights and only keep them in intervals of 100?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants