From 3cf4fec2898837dc5c63ed62c7143af466bce250 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?= Date: Sat, 21 Dec 2024 02:56:20 -0300 Subject: [PATCH] [smallcaps_before_ligatures] should not have is_ttf condition This check works just fine on OTFs, no need for `conditions=["is_ttf"]`. smallcaps_before_ligatures On the Universal profile (issue #4920) --- CHANGELOG.md | 3 +++ Lib/fontbakery/checks/smallcaps_before_ligatures.py | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4abf663ee..793a8f982c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,9 @@ A more detailed list of changes is available in the corresponding milestones for - **[kerning_for_non_ligated_sequences]**: "Is there kerning info for non-ligated sequences?" (issue #2954 / https://github.com/simoncozens/fontspector/commit/eaa52447ddc4a42e26b6430841a43026870d8a48) ### Changes to existing checks +### On the Universal profile + - **[smallcaps_before_ligatures]:** This check works just fine on OTFs, no need for `conditions=["is_ttf"]` (issue #4920) + ### On the Google Fonts profile - **[googlefonts/axes_match]:** Skip if remote_style is static diff --git a/Lib/fontbakery/checks/smallcaps_before_ligatures.py b/Lib/fontbakery/checks/smallcaps_before_ligatures.py index 94d7bc1c11..3999e0d59b 100644 --- a/Lib/fontbakery/checks/smallcaps_before_ligatures.py +++ b/Lib/fontbakery/checks/smallcaps_before_ligatures.py @@ -16,7 +16,6 @@ This check attempts to detect this kind of mistake. """, proposal="https://github.com/fonttools/fontbakery/issues/3020", - conditions=["is_ttf"], ) def check_smallcaps_before_ligatures(ttFont): """