From dfab4cbabc323b880d6a51bcc3b569a25b9fe97d Mon Sep 17 00:00:00 2001
From: Martin Ortbauer <mortbauer@gmail.com>
Date: Fri, 15 Mar 2024 08:13:38 -0500
Subject: [PATCH] integrate recommendations from rubocop

---
 .../app/controllers/messages_controller.rb       | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/plugins/messages/app/controllers/messages_controller.rb b/plugins/messages/app/controllers/messages_controller.rb
index 05815b735..d18477a26 100644
--- a/plugins/messages/app/controllers/messages_controller.rb
+++ b/plugins/messages/app/controllers/messages_controller.rb
@@ -34,17 +34,15 @@ def create
     ActiveRecord::Base.transaction do
       @current_user.with_lock do
         @message = @current_user.send_messages.new(params[:message])
-        if @message.save
-          DeliverMessageJob.perform_later(@message)
-          redirect_to messages_url, notice: I18n.t('messages.create.notice')
-        else
-          raise ActiveRecord::Rollback # Rollback the transaction if the save fails
-        end
+        raise ActiveRecord::Rollback unless @message.save
+
+        DeliverMessageJob.perform_later(@message)
+        redirect_to messages_url, notice: I18n.t('messages.create.notice')
       end
     end
-    rescue ActiveRecord::RecordInvalid => e
-      # Handle validation errors
-      render action: 'new'
+  rescue ActiveRecord::RecordInvalid
+    # Handle validation errors
+    render action: 'new'
   end
 
   # Shows a single message.