Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue #62 in the branch DEV #64

Closed
wants to merge 2 commits into from
Closed

Fix the issue #62 in the branch DEV #64

wants to merge 2 commits into from

Conversation

mniak
Copy link

@mniak mniak commented Dec 26, 2017

Create method Read(StreamReader) in the class FixedLengthFileMultiEngine and exposes it in the IFlatFileMultiEngine interface

@mniak
Copy link
Author

mniak commented Dec 26, 2017

The build failed, but it's not caused by the changes I made.
AppVeyor says that nuget restore failed, but as you can see, I've not changed anything related to NuGet.

Error: 12/26/2017 1:37:07 PM: 
 +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [<<==>>] Exception: Exec: Error executing command  .$nuget restore $solution_path .
ERROR CODE: 1
Command exited with code 1

@mniak
Copy link
Author

mniak commented Dec 26, 2017

Tried to trigger build again but still not working.
I dont know what is happening but the code is fine

/// </summary>
/// <param name="streamReader">The stream reader.</param>
/// <exception cref="ParseLineException">Impossible to parse line</exception>
public void Read(StreamReader reader)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this should be part of the contacts. We already have the ability to pass in a stream.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually would like the feature as well. I needed to use a custom StreamReader implementation for reading my files and ended up downcasting the engine to use that overload.

@mniak mniak closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants