From 4529c8fd2b697638dbc6ace0d34051c2ca7f1c23 Mon Sep 17 00:00:00 2001
From: Phillip Carter <pcarter@fastmail.com>
Date: Fri, 5 Oct 2018 09:36:29 -0700
Subject: [PATCH] Do not show symbols from unopened places by default (#5739)

---
 .../src/FSharp.Editor/Completion/CompletionProvider.fs        | 2 +-
 vsintegration/src/FSharp.Editor/Options/EditorOptions.fs      | 4 ++--
 .../src/FSharp.UIResources/IntelliSenseOptionControl.xaml     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs b/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
index fa1101d18de..fec42d030f7 100644
--- a/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
+++ b/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
@@ -221,7 +221,7 @@ type internal FSharpCompletionProvider
             let! _parsingOptions, projectOptions = projectInfoManager.TryGetOptionsForEditingDocumentOrProject(document)
             let! textVersion = context.Document.GetTextVersionAsync(context.CancellationToken)
             let getAllSymbols(fileCheckResults: FSharpCheckFileResults) =
-                if settings.IntelliSense.ShowAllSymbols
+                if settings.IntelliSense.IncludeSymbolsFromUnopenedNamespacesOrModules
                 then assemblyContentProvider.GetAllEntitiesInProjectAndReferencedAssemblies(fileCheckResults)
                 else []
             let! results = 
diff --git a/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs b/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
index 1728637ea04..47dcad5a029 100644
--- a/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
+++ b/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
@@ -28,12 +28,12 @@ type EnterKeySetting =
 type IntelliSenseOptions =
   { ShowAfterCharIsTyped: bool
     ShowAfterCharIsDeleted: bool
-    ShowAllSymbols : bool
+    IncludeSymbolsFromUnopenedNamespacesOrModules : bool
     EnterKeySetting : EnterKeySetting }
     static member Default =
       { ShowAfterCharIsTyped = true
         ShowAfterCharIsDeleted = true
-        ShowAllSymbols = true
+        IncludeSymbolsFromUnopenedNamespacesOrModules = false
         EnterKeySetting = EnterKeySetting.NeverNewline}
 
 
diff --git a/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml b/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml
index 7eb21c35559..dbb7b6bb8fc 100644
--- a/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml
+++ b/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml
@@ -25,7 +25,7 @@
                             <CheckBox x:Name="charDeleted" IsEnabled="{Binding IsChecked, ElementName=charTyped}" IsChecked="{Binding ShowAfterCharIsDeleted}"
                         Content="{x:Static local:Strings.Show_completion_list_after_a_character_is_deleted}"/>
                         </StackPanel>
-                        <CheckBox x:Name="showAllSymbols" IsChecked="{Binding ShowAllSymbols}"
+                        <CheckBox x:Name="showAllSymbols" IsChecked="{Binding IncludeSymbolsFromUnopenedNamespacesOrModules}"
                       Content="{x:Static local:Strings.Show_all_symbols}"/>
                     </StackPanel>
                 </GroupBox>