Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects ES Module exports in package.json #5736

Open
wants to merge 2 commits into
base: 5.0.x
Choose a base branch
from

Conversation

manuelroth
Copy link

This PR correct the ES Module exports in package.json

@travist
Copy link
Member

travist commented Aug 13, 2024

I actually agree with this change, but us using "cjs" for "import" was changed deliberately. Using mjs was causing some downstream issues with our build process and was not working with applications using legacy versions. Maybe pulling in your other pull request will resolve that issue, so we will give it a try and see what happens downstream due to these changes.

@manuelroth
Copy link
Author

I think its also important to define the type and module properties. See 4113097. This way bundlers will know which entrypoint to use for CommonJS and ES Module.

@manuelroth
Copy link
Author

Hi @travist , were you able to test the changes downstream?- We still have to keep the workaround described in #5735 (comment) in place. I would be glad if we could remove it at some point. Therefore it would be great to know if you have made an progress on this issue. Kind regards, Manuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants