update wasi rust target to wasip1 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting in rust 1.84, the wasi target is removed this broke the latest CI build on master
jethrogb
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust 1.84, the
wasm32-wasitarget has been removed (see here).From 2024/11/7 on, nightly rust uses 1.84, which broke the latest CI build on master; this PR fixes the build by:
was32-wasip1targetcargo wasi, which does not support thewasm32-wasip1target. I expect that cases that would fail runs of the rawcargo testwould've failedcargo wasi testbefore as well. For example, tests could fail if file-system access is required (see e.g. cargo wasi test should preopen the current dir by default bytecodealliance/cargo-wasi#128), or if other parts of the WASI API are exercised as part of Rust syscalls.