Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen to latest version (0.65.1) to fix "not a valid Ident" error #273

Merged
merged 1 commit into from
May 22, 2023

Conversation

sburton84
Copy link
Contributor

Trying to build mbedtls-sys-auto on my machine was resulting in the following error:

  thread 'main' panicked at '"x509_san_other_name_union_(unnamed_at_vendor/include/mbedtls/x509_crt_h_115_5)" is not a valid Ident', /home/sburton/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.58/src/fallback.rs:811:9

I'm not sure exactly what change on my machine causes this, it fails even when using the same rustc version as previously worked, could possibly be related to updating installed LLVM version?

Regardless, updating the bindgen version being used fixes the issue. This PR just updates bindgen (plus changes the call to rustfmt_bindings which has been deprecated).

@Taowyoo
Copy link
Collaborator

Taowyoo commented May 22, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented May 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0666c30 into fortanix:master May 22, 2023
@Taowyoo Taowyoo mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants