Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket PDF should exist for each attendee #7397

Closed
iamareebjamal opened this issue Oct 30, 2020 · 5 comments · Fixed by #7458, #7462, #7471 or fossasia/open-event-frontend#5806
Closed

Ticket PDF should exist for each attendee #7397

iamareebjamal opened this issue Oct 30, 2020 · 5 comments · Fixed by #7458, #7462, #7471 or fossasia/open-event-frontend#5806
Labels

Comments

@iamareebjamal
Copy link
Member

Ticket PDF is currently associated with an order which should instead be associated with an attendee as each attendee should have a ticket

@codedsun
Copy link
Contributor

Taking this up!

@codedsun
Copy link
Contributor

codedsun commented Oct 31, 2020

@iamareebjamal - The ticket holder table has the column pdf_url which holds the value of the Ticket PDF. Can you explain me more here?

@iamareebjamal
Copy link
Member Author

There is a single endpoint to download tickets for an order -

@ticket_blueprint.route('/<string:order_identifier>')
@order_blueprint.route('/<string:order_identifier>/tickets-pdf')
@jwt_required
def ticket_attendee_authorized(order_identifier):

This means I cannot download it for individual attendees

@mariobehling
Copy link
Member

mariobehling commented Nov 14, 2020

To clarify: Feature-wise we need both a) a way to download all tickets in an order in one PDF and b) a way to download each ticket and share access of different tickets within an order with the (intended) ticket holder.

Who has access to tickets?

  1. The account/person who has made the order has access to all tickets of an order.
  2. Different tickets within an order can be bought for different people. Each person has their own email address (and possibly existing account on the system, e.g. eventyay). So, each person should have access to the ticket(s) associated with their email address, but they should not have access to other tickets within the same order.

@mariobehling
Copy link
Member

mariobehling commented Nov 14, 2020

Other questions that need to be handled in subsequent issues (this is getting rather complex permission-wise):

  • Who has access to the order invoice? -> Only the person ordering the tickets has access. Other people should be able to see the button "invoice" on their complete ticket/order page, but when they click on it (coming from the "My Tickets" page), they should see a message "Only the account that made the order is able to access this invoice."
  • If a user has access to their tickets, they should not be able to see the list of all other tickets that are within that order, if they are not the account that made the order (the owner of the order). In that case show a message, e.g. with a star at the bottom of the table and within the box - something like *Only the person or account that made the order is able to see all tickets in this order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment