Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order complete and email sending logic #7412

Closed
iamareebjamal opened this issue Nov 4, 2020 · 0 comments · Fixed by #7418
Closed

Fix order complete and email sending logic #7412

iamareebjamal opened this issue Nov 4, 2020 · 0 comments · Fixed by #7418
Assignees
@iamareebjamal
Labels
admin Priority: High Priority: URGENT

Comments

@iamareebjamal
Copy link
Member

The order complete logic is duplicated in 5 places and really really messed up. It is impossible to figure out what'll happen when with subtle differences. This is the reason why attachments to users were not working in the first place.

Fix and deduplicate the logic once and for all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamareebjamal iamareebjamal

Labels
admin Priority: High Priority: URGENT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ref): Refactor order complete logic iamareebjamal/open-event-server
1 participant
@iamareebjamal