Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge selector upload doesn't support errors #5241

Closed
1 of 2 tasks
thedavidmeister opened this issue Jun 28, 2023 · 2 comments
Closed
1 of 2 tasks

forge selector upload doesn't support errors #5241

thedavidmeister opened this issue Jun 28, 2023 · 2 comments
Labels
T-bug Type: bug

Comments

@thedavidmeister
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (e6574c9 2023-06-25T00:10:48.177241000Z)

What command(s) is the bug in?

forge selectors upload --all

Operating System

macOS (Apple Silicon)

Describe the bug

This issue makes me think it is expected that error selectors are uploaded

#5012

e.g.

Supports additive --functions, --errors, --events flags to specify a subset of the above, e.g. if you only want error selectors

But from what I can see only functions and event selectors are uploaded.

Definitely makes sense to be able to upload and reference error selectors e.g. #3656

I wasn't sure whether to file this as a bug or feature request, but it was unexpected enough for me to feel like it's more of a bug.

@thedavidmeister
Copy link
Author

i think maybe it does support errors now, but not explicitly

at least, when i go to openchain.xyz i can see the error selectors listed as function selectors

@DaniPopes
Copy link
Member

Yes, see #5293 (comment)

@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants