feat(improvement): identify contracts by hash, not bytecode

[DaniPopes]

Component

Forge

Describe the feature you would like

We already collect coverage hitmaps by bytecode hash, we can use this to avoid the hacky heuristics of finding a matching artifact using the bytecode itself.

• In this loop, the key is the bytecode hash, which is currently ignored:

  foundry/crates/forge/bin/cmd/coverage.rs

  Line 253 in 7a23a5c

  for map in hit_maps.0.values() {

• We try to find a match using bytecodes with ContractsByArtifact::find_by*

  foundry/crates/forge/bin/cmd/coverage.rs

  Lines 254 to 260 in 7a23a5c

  	if let Some((id, _)) = known_contracts.find_by_deployed_code(&map.bytecode) {
  	hits.push((id, map, true));
  	} else if let Some((id, _)) =
  	known_contracts.find_by_creation_code(&map.bytecode)
  	{
  	hits.push((id, map, false));
  	}

This also applies to all the other callsites of these functions, except for the getArtifactPathBy[Deployed]Code cheatcodes, where we would have to compute the hash ourselves.

By computing the hashes of the bytecodes and looking up the artifacts by code hash, we will be able to get rid of the find_by*code functions altogether.

cc @klkvr @grandizzy

Additional context

No response

[klkvr]

I don't think we can rely on pre-computed bytecode hashes for artifacts due to immutables?